release: prepare Socket v10.0.2 - #192
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13956dfe0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| docs_code, docs_payload, docs_stderr = run_documentation( | ||
| repo_root, documentation_mode | ||
| ) |
There was a problem hiding this comment.
When bootstrap-xcode-workspace creates a workspace, it writes marked AGENTS.md and CONTRIBUTING.md files and then reaches this new documentation pass through the xcode-workspace install. The generic owner workflows insert their required sections between <!-- socket-managed:begin --> and <!-- socket-managed:end -->, but the generated .socket/managed/align.sh later replaces that entire span from the original minimal Apple assets. Consequently, the documented just align command silently removes the canonical sections added here, and the next repository refresh adds them again. Use profile-specific document inputs or place canonical content outside the replace span so the two owning automations do not oscillate.
AGENTS.md reference: AGENTS.md:L34-L39
Useful? React with 👍 / 👎.
| proc = subprocess.run(command, capture_output=True, text=True, check=False) | ||
| payload = json.loads(proc.stdout) if proc.stdout.strip() else { | ||
| return_code = proc.returncode | ||
| payload = decode_payload(proc, { |
There was a problem hiding this comment.
If the installer exits zero but emits empty, malformed, or non-object JSON, decode_payload returns this status: failed fallback while return_code remains zero. The runner then executes the documentation mutations and ultimately exits successfully, so callers such as the Xcode bootstrap accept a result that explicitly says the installer failed. Treat a fallback decode as a nonzero workflow result instead of preserving the subprocess return code.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
uv run scripts/validate_socket.py --profile fullscripts/release.sh prepare 10.0.2