release: prepare Socket v10.0.0 - #190
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fcad9c090
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| root guidance audit: PASS | ||
| root documentation audit: PASS |
There was a problem hiding this comment.
When maintainers use this plan to reproduce the validation, these two PASS results refer to checks that no longer exist: a repo-wide search finds no root guidance or documentation audit command, and this commit removes every root-guidance assertion except the Speak Swiftly mirror check. Consequently, the plan's exit criterion and final-validation claim cannot be verified and may conceal future guidance drift; retain runnable audits or name only the checks that actually ran.
AGENTS.md reference: AGENTS.md:L38-L39
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 640bdae056
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if overlong_descriptions: | ||
| raise ValidationError( | ||
| "Hermes skill descriptions exceed the maximum length:\n- " | ||
| + "\n- ".join(overlong_descriptions) |
There was a problem hiding this comment.
When maintainers follow docs/maintainers/hermes-compatibility.md and add an exported description over 240 characters, the guide still says this validator only emits a non-blocking warning, but this new exception now fails the compatibility, full, and release validation profiles. Update the owning guide to describe the hard limit, or retain the documented warning behavior, so contributors are not surprised by a release-blocking failure.
AGENTS.md reference: AGENTS.md:L38-L39
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
uv run scripts/validate_socket.py --profile fullscripts/release.sh prepare 10.0.0