plugin: update Things security and XcodeGen defaults - #177
Conversation
|
Warning Review limit reached
Next review available in: 48 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe XcodeGen SwiftUI app template now enables string catalog defaults, generates test-target Info.plists, excludes ChangesXcodeGen template defaults
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 742f4165c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
plugins/apple-dev-skills/tests/test_xcode_app_bootstrap_workflow.py (1)
321-332: 🗄️ Data Integrity & Integration | 🔵 Trivial | 🏗️ Heavy liftAdd separate Xcode integration coverage for the generated project.
Keep this tool-free unit test. Add a separately gated macOS integration test that runs real
xcodegen generate, checksxcodebuild -showBuildSettings, builds the generated scheme, and checks the generated symbol sources.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/apple-dev-skills/tests/test_xcode_app_bootstrap_workflow.py` around lines 321 - 332, Add a separately gated macOS integration test alongside the existing tool-free assertions in the Xcode app bootstrap workflow tests. Have it invoke real xcodegen generate, inspect xcodebuild -showBuildSettings, build the generated scheme, and verify the generated localization symbol sources; leave the current unit test unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@plugins/apple-dev-skills/tests/test_xcode_app_bootstrap_workflow.py`:
- Around line 321-332: Add a separately gated macOS integration test alongside
the existing tool-free assertions in the Xcode app bootstrap workflow tests.
Have it invoke real xcodegen generate, inspect xcodebuild -showBuildSettings,
build the generated scheme, and verify the generated localization symbol
sources; leave the current unit test unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 10d6bc0d-5449-4293-9678-9a1f85f240c7
⛔ Files ignored due to path filters (1)
plugins/things-app/mcp/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
plugins/apple-dev-skills/templates/xcodegen/swiftui-app/Configurations/Shared.xcconfig.tmplplugins/apple-dev-skills/templates/xcodegen/swiftui-app/Configurations/Tests.xcconfig.tmplplugins/apple-dev-skills/templates/xcodegen/swiftui-app/project.yml.tmplplugins/apple-dev-skills/tests/test_xcode_app_bootstrap_workflow.py
|
Addressed the integration-coverage suggestion in 5adb89c. The opt-in macOS test now bootstraps a real XcodeGen app, checks all four requested build settings through xcodebuild -showBuildSettings, runs xcodebuild test, and verifies GeneratedAssetSymbols.swift plus GeneratedStringSymbols_Localizable.swift. The existing bootstrap tests also verify the checked-in Assets.xcassets and Localizable.xcstrings templates. Verified locally: the opt-in integration test passed (9 tests), the normal Apple Dev suite passed (290 plus one intentionally skipped), and Socket metadata validation passed. |
|
Addressed the documentation finding in c2874b6. The bootstrap generator reference now documents the default String Catalog, generated localization-symbol settings, test-bundle Info.plist requirement, and placeholder exclusion; the Apple Dev roadmap records the completed scaffold contract. The test-bundle setting and .gitkeep exclusion are necessary to make a freshly generated app pass the required xcodebuild test acceptance path. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2874b63a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "-scheme", | ||
| "TemplateProbe", | ||
| "-destination", | ||
| "platform=macOS,arch=arm64", |
There was a problem hiding this comment.
In the new opt-in XcodeGen integration test, hard-coding the destination to arch=arm64 makes APPLE_DEV_SKILLS_RUN_XCODEGEN_INTEGRATION=1 fail on Intel macOS hosts and Intel GitHub runners because they cannot execute the generated ARM test bundle. Omit the architecture so Xcode selects the host Mac, or derive it from the current machine.
Useful? React with 👍 / 👎.
1 participant
No description provided.