Fix UnboundLocalError while recovering from an error#837
Open
mgedmin wants to merge 1 commit into
Open
Conversation
See furlongm#690 (comment): if you upgrade a Patchman 3 setup to Patchman 4, the migrations don't correctly alter the hosts_host table and leave the tags column as NOT NULL, which then causes issues processing reports for previously unseen hosts. Host.objects.get_or_create() raises, the exception is caught and logged, and then subsequent `if host:` check fails with an UnboundLocalError: cannot access local variable 'host' where it is not associated with a value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #690 (comment): if you upgrade a Patchman 3 setup to Patchman 4, the migrations don't correctly alter the hosts_host table and leave the tags column as NOT NULL, which then causes issues processing reports for previously unseen hosts. Host.objects.get_or_create() raises, the exception is caught and logged, and then subsequent
if host:check fails with an(This commit doesn't actually fix the processing error itself, you need a database schema fix for that -- drop the no-longer-used
tagscolumn from thehosts_hosttable.)