Skip to content

SRVOCF-946: Add Husky pre-commit hook with lint, type-check, and Go checks #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cragsmann wants to merge 1 commit into
base: master
Choose a base branch
from
+26 −0
Open

SRVOCF-946: Add Husky pre-commit hook with lint, type-check, and Go checks #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/usr/bin/env sh

yarn lint:fix
yarn type-check

cd backend
go vet ./...
if [ -n "$(gofmt -l .)" ]; then
echo "Go files not formatted. Run: gofmt -w backend/"
gofmt -l .
exit 1
fi
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
"cypress-merge": "mochawesome-merge ./integration-tests/screenshots/cypress_report*.json > ./integration-tests/screenshots/cypress.json",
"cypress-generate": "marge -o ./integration-tests/screenshots/ -f cypress-report -t 'OpenShift Console Plugin Template Cypress Test Results' -p 'OpenShift Cypress Plugin Template Test Results' --showPassed false --assetsDir ./integration-tests/screenshots/cypress/assets ./integration-tests/screenshots/cypress.json",
"cypress-postreport": "yarn cypress-merge && yarn cypress-generate",
"type-check": "tsc --noEmit",
"prepare": "husky",
"webpack": "node -r ts-node/register ./node_modules/.bin/webpack"
},
"devDependencies": {
Expand Down Expand Up @@ -56,6 +58,7 @@
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-hooks": "^7.0.1",
"globals": "^17.4.0",
"husky": "^9.1.7",
"i18next": "^23.11.5",
"i18next-parser": "^9.4.0",
"jsdom": "^29.0.2",
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"allowJs": true,
"strict": true,
"noUnusedLocals": true,
"skipLibCheck": true,
"types": ["vitest/globals"]
},
"include": ["src", "testing"],
Expand Down
10 changes: 10 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5569,6 +5569,7 @@ __metadata:
eslint-plugin-react: "npm:^7.37.5"
eslint-plugin-react-hooks: "npm:^7.0.1"
globals: "npm:^17.4.0"
husky: "npm:^9.1.7"
i18next: "npm:^23.11.5"
i18next-parser: "npm:^9.4.0"
jsdom: "npm:^29.0.2"
Expand Down Expand Up @@ -8997,6 +8998,15 @@ __metadata:
languageName: node
linkType: hard

"husky@npm:^9.1.7":
version: 9.1.7
resolution: "husky@npm:9.1.7"
bin:
husky: bin.js
checksum: 10c0/35bb110a71086c48906aa7cd3ed4913fb913823715359d65e32e0b964cb1e255593b0ae8014a5005c66a68e6fa66c38dcfa8056dbbdfb8b0187c0ffe7ee3a58f
languageName: node
linkType: hard

"hyperdyperid@npm:^1.2.0":
version: 1.2.0
resolution: "hyperdyperid@npm:1.2.0"
Expand Down