fix: List page crashes and missing rows#40
Conversation
|
via Claude: ReviewBlockingEdit link breaks when The list page now uses the But When
The Non-blocking
|
|
Both issues confirmed and fixed: 1. Edit link (blocking): Added 2. Silent error swallowing (non-blocking): Changed the bare |
|
Looks good to me. @twoGiants are we OK with just logging the error for a developers into console, |
| return newItem(name || repo.name, repo.name, namespace, runtime); | ||
| } catch (err: unknown) { | ||
| console.warn(`Skipping repo ${repo.name}: ${err instanceof Error ? err.message : err}`); | ||
| return null; |
There was a problem hiding this comment.
Idea: maybe we could return some partially filled object with placeholders and error status.
E.g.
const item = newItem(repo.name, repo.name, "<UNKNOW>", "<UNKNOW>");
item.status = "Error"; // maybe append error from the exception?
return item;@twoGiants @Cragsmann wdyt?
|
plz update ./docs/claude-progress.txt |

Summary
loadFunctionTableItemsso a deleted GitHub repo no longer crashes the entire list page (repos that fail to load are silently skipped)func.yamlinstead of repo name as the correlation key, so cluster matching works when the two differparseNamespaceAndRuntimetoparseFuncYamland extract thenamefieldFixes SRVOCF-840
Test plan
namediffers from repo name. List page shows the func.yaml name and matches cluster status correctly