retry flaky e2e specs once - #192
Merged
Merged
Conversation
The slowest healthy spec in s2i/knative takes 498s against a 600s default Eventually timeout, only 17% headroom, while ginkgo runs 4 specs in parallel on a 4-core runner. Under contention a normally-8-minute spec overruns and the whole job fails, blocking dependabot auto-merge. The imagePullSecrets spec timed out at 600s on three unrelated branches; PR 176 failed it in the merge queue and passed on retry with identical code, so it is a flake and not a regression. --flake-attempts=2 retries a failed spec once and only costs time when a spec actually fails. Left off test-e2e-bundle, which has no failures in the last 93 runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slowest healthy spec in s2i/knative takes 498s against a 600s default Eventually timeout, only 17% headroom, while ginkgo runs 4 specs in parallel on a 4-core runner. Under contention a normally-8-minute spec overruns and the whole job fails, blocking dependabot auto-merge.
The imagePullSecrets spec timed out at 600s on three unrelated branches; PR 176 failed it in the merge queue and passed on retry with identical code, so it is a flake and not a regression.
--flake-attempts=2 retries a failed spec once and only costs time when a spec actually fails. Left off test-e2e-bundle, which has no failures in the last 93 runs.