fix(app): give team-status-rail its own gray for zero-pane teams#413
Open
fujibee wants to merge 1 commit into
Open
fix(app): give team-status-rail its own gray for zero-pane teams#413fujibee wants to merge 1 commit into
fujibee wants to merge 1 commit into
Conversation
#406 made "unknown" (a pane whose agent type classify() doesn't recognize) render green like idle. But aggregateTeamStatus also returned "unknown" for a team with zero panes at all, so a team nobody has started an agent in looked identical to one full of healthy unrecognized agents. aggregateTeamStatus now returns a distinct "empty" for that case, which keeps the muted-gray base color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unknown(a pane whose agent typeclassify()doesn't recognize) render green like idle. ButaggregateTeamStatusalso returnedunknownfor a team with zero panes at all, so a team nobody has started an agent in looked identical to one full of healthy unrecognized agents.aggregateTeamStatusnow returns a distinct"empty"for the zero-pane case, which keeps the muted-gray base color (.team-status-dot.status-emptyadded explicitly for clarity, though it matches the existing base).Test plan
pnpm exec tsc --noEmitpnpm test(130 pass, incl. updated/newaggregateTeamStatuscases)