Add age-based cleanup for simplecache - #2118
Open
be-student wants to merge 2 commits into
Open
Conversation
Member
|
Runs into the following issue on windows (seen in the test): |
Test-only path normalization follows the cache lookup contract on Windows. Production behavior and public documentation are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2105.
SimpleCacheFileSystemdoes not persist cache metadata, so its inheritedclear_expired_cache()had no records to inspect and silently retained every cached file. This override uses each cached file's local modification time, requires an explicit non-negative maximum age, and only modifies the writable cache location.The regression tests cover files retained after writes, selective age-based removal, and invalid expiry arguments. The feature documentation and changelog now describe manual age-based cleanup.
Validation:
pytest -q fsspec/implementations/tests/test_cached.py(79 passed, 31 skipped)test_posix_tests_bash_stat, reproduced unchanged on a cleanupstream/masterworktree because BSDstatdoes not support-c