Conversation
Replace deprecated '!cell' with 'cell.Value' and 'cell := expr' with 'cell.Value <- expr' throughout AsyncSeq.fs and the Fable test file, eliminating all FS3370 compiler info warnings. Closes #310 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated response from Repo Assist, triggered by @dsyme's
/repo-assist fix these pleasecomment on #310.Fixes all
FS3370compiler info warnings from #310 by replacing the deprecated F# refcell operators throughout the codebase:!cell→cell.Valuecell := expr→cell.Value <- exprFiles changed:
src/FSharp.Control.AsyncSeq/AsyncSeq.fs— 20 occurrences intryWith,tryFinally,ofSeq, and the split/merge helperstests/fable/FSharp.Control.AsyncSeq.Tests/AsyncSeq.test.fs— 8 occurrences in the try/finally/with and intervalMs testsCloses #310
Test Status
✅ Build succeeded — 0 errors, 7 pre-existing warnings (unrelated
FS9999groupBy warnings)✅ All 411 tests pass (
dotnet test FSharp.Control.AsyncSeq.sln)✅ No
FS3370deprecation warnings remain