Icons and cleanup - #8
Conversation
…tralized socials configuration
…r improved performance
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76fa728472
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| const siteUrl = 'https://frontendfixer.dev'; | ||
| const siteUrl = import.meta.env.VITE_SITE_URL; |
There was a problem hiding this comment.
In any build that does not define VITE_SITE_URL, siteConfig.url becomes undefined; because <SEO /> renders on every page and resolveUrl() immediately calls siteConfig.url.replace(...), the app throws before the home page can render. The previous hard-coded URL avoided this, so keep a fallback such as https://frontendfixer.dev or validate the env var before using it.
Useful? React with 👍 / 👎.
| if ( | ||
| !EMAILJS_CREDENTIALS.serviceId || | ||
| !EMAILJS_CREDENTIALS.templateId || | ||
| !EMAILJS_CREDENTIALS.publicKey | ||
| ) { | ||
| return setStatus('rejected'); |
There was a problem hiding this comment.
For deployments or local builds where the new VITE_EMAILJS_* variables are not all configured, this branch returns rejected before calling emailjs.sendForm, so every valid contact submission shows “Failed to send.” Since this patch removes the previously working hard-coded EmailJS service/template/public key, add fallbacks or ensure the deployment path provides these variables before relying on them.
Useful? React with 👍 / 👎.
…ion, and streamlined state management
1 participant
No description provided.