FR-26617: harden the venv AI agent suite - #119
Open
yaronblum-frontegg wants to merge 1 commit into
Open
Conversation
Pins --reporter=list so the Total line the size guard greps is not an accident of reporter order, fails on pipe errors, trims the secrets contract to the one secret this workflow references (callers inherit the rest), and runs six specs in two shards instead of three. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #118 (merged), applying the adversarial-review findings to the suite:
--reporter=listpinned on the size guard. TheTotal: N testsline it greps is only printed by the list-mode reporter; today it appears because the config's CI reporter set happens to includedot. Reorder those reporters and the guard would go permanently red. Also addsset -o pipefail.GH_REPOSITORY_ADMIN_TOKEN— the only secret this workflow references itself (venv removal). All callers usesecrets: inherit, and the 11 other declarations would hard-fail any caller missing one while documenting names that don't even match the downstream workflow.Not changed, deliberately:
continue_on_test_failurestays as a command-level|| warningbecause GitHub does not allowcontinue-on-erroron a job withuses:; andremove-venvstill keeps the venv on failure for debugging (note the lease reaperhouse-cleaner.yamlin frontegg/venv is currently commented out, so leaked venvs persist until someone runsremove-all-venvs— worth re-enabling).🤖 Generated with Claude Code