Skip to content

fix(dashboard): Improve verify-email UX: auth shell layout and clearer modal - #2789

Merged
mekilis merged 4 commits into
mainfrom
improve-email-ux
Aug 18, 2026
Merged

fix(dashboard): Improve verify-email UX: auth shell layout and clearer modal#2789
mekilis merged 4 commits into
mainfrom
improve-email-ux

Conversation

@motunrayokoyejo

@motunrayokoyejo motunrayokoyejo commented Aug 14, 2026

Copy link
Copy Markdown
Contributor
  • Put /verify-email on the shared auth shell to match login/signup.
  • Tighten the in-app verify-email modal copy and close it after a successful resend so it doesn’t stay stuck.

Note

Medium Risk
Touches auth-related guest routes and resend targeting by verification token, which could mis-route resends if token handling is wrong; UI and config preload changes are lower risk.

Overview
Improves the verify-email flow end-to-end: public page matches login/signup via auth shell, and users can resend from the link page or the in-app modal without getting stuck after success or refresh.

Backend: POST /users/resend_verification_email is a guest route with optional auth. The handler prefers ?token= so resends target the user on the verification link (not whoever is signed in). getUser uses a safe context read so guest routes don’t panic. Cooldown errors now say to wait 1 minute.

Frontend: /verify-email is registered at the app root (not under legacy public chrome). After verify, the URL token is cleared and a sessionStorage flag preserves success on refresh; failed verify can resend with the token query param. The dashboard modal closes after a successful resend and keeps tighter copy. ConfigService dedupes the default auth config fetch and falls back to defaults on failure (with hideNotification on preload).

Reviewed by Cursor Bugbot for commit ba4708a. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread web/ui/dashboard/src/app/public/verify-email/verify-email.component.html Outdated

@mekilis mekilis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise. One ask on the failed-state button.

Comment thread web/ui/dashboard/src/app/public/verify-email/verify-email.component.html Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ba4708a. Configure here.

Comment thread web/ui/dashboard/src/app/app.module.ts
@mekilis
mekilis added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit b6aa65d Aug 18, 2026
36 checks passed
@mekilis
mekilis deleted the improve-email-ux branch August 18, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants