[fix] Fix top-level CUDAGraph export - #8
Open
matteso1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Nils Matteson <nilsmatteson@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The top-level package imports the Python
CUDAGraphwrapper and then appliesfrom .ops import *. The native extension exports the same name. Its wildcard import therefore replaces the wrapper. As a result,foundry.CUDAGraphresolves to the raw binding instead of the documented Python wrapper.The fix
Import the native re-exports first, then explicitly re-export
foundry.graph.CUDAGraph. Add a regression to the existing import test that checks the top-level name resolves to the Python wrapper.Test plan
pytest -q tests/test_imports.py::test_cudagraph_reexport_uses_python_wrapperruff check python/foundry/__init__.py tests/test_imports.pyruff format --check python/foundry/__init__.py tests/test_imports.pyThe focused test passed in the built Linux environment. On one RTX 4090 Laptop GPU, the low-level SAVE oracle passed in 4.2557 seconds, n=1. The LOAD oracle passed in 2.3335 seconds, n=1.
I used AI assistance. I reviewed the change and can defend the implementation and verification.