Skip to content

Fix cookie case sensitive name#889

Open
rajwinder-dev wants to merge 2 commits into
forwardemail:masterfrom
rajwinder-dev:fix-cookie-case-sensitive-name
Open

Fix cookie case sensitive name#889
rajwinder-dev wants to merge 2 commits into
forwardemail:masterfrom
rajwinder-dev:fix-cookie-case-sensitive-name

Conversation

@rajwinder-dev
Copy link
Copy Markdown

@rajwinder-dev rajwinder-dev commented May 26, 2026

Summary

Preserve cookie name casing during cookie parsing.

Cookie attribute keys are still normalized to lowercase
(case-insensitive), but cookie names should remain
case-sensitive.

Changes

  • Preserve original casing for cookie names
  • Continue lowercasing cookie option keys
  • Add test coverage for mixed-case cookie names

Reason

Cookie names are case-sensitive, but the parser was
lowercasing all keys including the cookie name.

Resolves #879

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cookie names are converted to lower case, causing cookie assertion failures

2 participants