fix: flint: missed overall factor in univariate polynomial factorization#860
Merged
Merged
Conversation
jodavies
force-pushed
the
flint-fix-poly-fact
branch
from
80e42f0 to
ee3a508
Compare
|
coverage: 63.145% (+0.001%) from 63.144% — jodavies:flint-fix-poly-fact into form-dev:master |
The flint interface assumed that univariate polynomials have no overall factor, when factorizing. This is usually the case, but changing the sort ordering with for eg "On highfirst" combined with non-dirty arguemnts (which are not re-sorted) can produce input for flint with an overall factor.
jodavies
force-pushed
the
flint-fix-poly-fact
branch
from
ee3a508 to
f3f4241
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flint interface assumed that univariate polynomials have no overall factor, when factorizing. This is usually the case, but changing the sort ordering with for eg "On highfirst" combined with non-dirty arguemnts (which are not re-sorted) can produce input for flint with an overall factor.
This one is nasty, since merging the flint interface FORM silently gives bad results in this (hopefully not common) scenario.