feat: require ! prefix for revision comments, ignore unprefixed#75
Open
eshulman2 wants to merge 2 commits into
Open
feat: require ! prefix for revision comments, ignore unprefixed#75eshulman2 wants to merge 2 commits into
eshulman2 wants to merge 2 commits into
Conversation
Users can now post informational comments (e.g. "looks good", "FYI") without triggering artifact regeneration. Only comments prefixed with ! are treated as revision requests. Comment syntax: - ! → revision (triggers regeneration) - ? → question (triggers Q&A) - >option N → RCA option selection - (no prefix) → informational (ignored) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
eshulman2
force-pushed
the
feat/revision-prefix
branch
from
c91a5cb to
7e8c304
Compare
2 tasks
Collaborator
|
I've tested the PR and can confirm that I am reproducing the exact issue with the executive summary disappearing. |
The previous implementation used text.find("\n#") which matched any
\n# anywhere — including #1 in numbered lists or heading-like patterns
in agent narration. This could strip actual document content like the
Executive Summary.
Now only looks within the first 10 lines and requires proper heading
format (# or ## followed by a space).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
eshulman2
force-pushed
the
feat/revision-prefix
branch
from
7e8c304 to
fce0cb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revision prefix for comments
Previously, any Jira comment that wasn't a question (
?prefix) would trigger artifact regeneration — meaning users couldn't post informational comments ("looks good", "FYI for the team") without accidentally kicking off a revision cycle.Now comments require an explicit
!prefix to trigger revisions. Unprefixed comments are treated as informational and ignored by the workflow.!?or@forge ask>option NFix: PRD section loss during revision
_strip_preambleusedtext.find("\n#")which matched any\n#anywhere — including#1in numbered lists or heading-like patterns in agent narration. This could strip actual document content (e.g., the Executive Summary section was being silently dropped after revisions).Fixed by:
_strip_preambleonly match proper headings (#,##,###with a space) within the first 5 linesTest plan
!Fix the auth sectionon a paused approval gate — verify regeneration triggers?Why REST?on a paused gate — verify Q&A answer is postedLooks good, thankson a paused gate — verify workflow stays paused (no regeneration)>option 2at RCA option gate — verify option selection still works🤖 Generated with Claude Code