Skip to content

proposal: auto-review primitive for skills#60

Open
JoshSalomon wants to merge 1 commit into
forge-sdlc:mainfrom
JoshSalomon:auto-review
Open

proposal: auto-review primitive for skills#60
JoshSalomon wants to merge 1 commit into
forge-sdlc:mainfrom
JoshSalomon:auto-review

Conversation

@JoshSalomon

Copy link
Copy Markdown
Contributor

Summary

Adds a proposal for an opt-in auto-review mechanism as a new primitive for skills. Any skill can include a review.md alongside SKILL.md to enable automatic worker→reviewer→fix loops.

Key Design Points

  • Opt-in: review.md alongside SKILL.md — no file means no review, current behavior preserved
  • Any skill: works for planning skills (PRD, spec) and execution skills (implementation, CI fix)
  • Separate reviewer agent: avoids confirmation bias — reviewer is a different agent than the worker
  • Per-skill retry config: max_retries in review.md frontmatter, global default fallback
  • File-based observability: container writes per-cycle JSON files, orchestrator polls for near-real-time Prometheus metrics and Jira comments

Maintainer Input Needed

The proposal presents two approaches for where the review loop lives:

  • Approach A (recommended): Container-internal loop with file-based observability — fast to implement, good context preservation, near-real-time metrics/Jira via filesystem polling
  • Approach B: Orchestrator-managed loop — full checkpoint persistence and human intervention mid-loop, but significantly more complex

See the comparison table in the proposal for the full tradeoff analysis.

Files Changed

  • proposals/auto-review-primitive.md — full proposal
  • proposals/README.md — index entry added

🤖 Generated with Claude Code

Introduces an opt-in review.md file alongside SKILL.md that enables
automatic worker→reviewer→fix loops for any skill. Includes two
architectural approaches for maintainer discussion, with file-based
observability for near-real-time metrics and Jira visibility.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant