NEW @W-21741487@ - Implement ApexGuru Engine Package in Code Analyzer Core Repository#448
Merged
nikhil-mittal-165 merged 13 commits intodevfrom Apr 14, 2026
Merged
NEW @W-21741487@ - Implement ApexGuru Engine Package in Code Analyzer Core Repository#448nikhil-mittal-165 merged 13 commits intodevfrom
nikhil-mittal-165 merged 13 commits intodevfrom
Conversation
|
Git2Gus App is installed but the |
nikhil-mittal-165
changed the title
Contributor
Author
|
Ignore apexGuruAuthService for now as this is tested on hardcoded tokens we will be taking auth dev in subsequent PRs |
aruntyagiTutu
approved these changes
Apr 13, 2026
namrata111f
reviewed
Apr 13, 2026
| // TODO: This destroys process-wide HTTP agents, which could interfere with | ||
| // concurrent HTTP work in the Code Analyzer process. We should investigate | ||
| // using custom agents specific to ApexGuru's Connection and destroy only | ||
| // those agents instead of the global ones. For now, this approach works |
Contributor
There was a problem hiding this comment.
Can we discuss or add here itself: What can be the side-effects of doing this?
namrata111f
reviewed
Apr 13, 2026
| let attempts = 0; | ||
|
|
||
| while (true) { | ||
| if (this.isCancelled) { |
Contributor
There was a problem hiding this comment.
We are not setting is value of isCancelled inside this loop? How will the request timeout?
namrata111f
reviewed
Apr 13, 2026
Comment on lines
+103
to
+109
| const response = await connection.request({ | ||
| method: 'GET', | ||
| url | ||
| }) as { status?: string }; | ||
|
|
||
| if (response.status && response.status.toLowerCase() === ApexGuruResponseStatus.SUCCESS) { | ||
| return; |
Contributor
There was a problem hiding this comment.
Can we have a separate file with boilerplate code for making the HTTP requests? If not as part of this PR we can add later on. But this looks like something which can be reused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mnaual testing doc : https://docs.google.com/document/d/1duMC0_481anO0Q36pJPa8nyDtpM5zEm23QRLz4CEb40/edit?tab=t.0#heading=h.7qosyh1yv1fz