Skip to content

Fix RGB JPEG embedded as DeviceGray (0.19.0 regression) #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blikblum merged 3 commits into from
Jun 9, 2026
+7 −1
Merged

Fix RGB JPEG embedded as DeviceGray (0.19.0 regression) #1734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78ec772
Initial plan
Copilot Jun 9, 2026
c8c8e8f
Fix RGB JPEG colorSpace regression: use data[pos] instead of data[pos+1]
Copilot Jun 9, 2026
55bdd9a
Revert yarn.lock changes
Copilot Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/image/jpeg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class JPEG {
this.width = this.data.readUInt16BE(pos);
pos += 2;

const channels = this.data[pos + 1];
const channels = this.data[pos];
this.colorSpace = COLOR_SPACE_MAP[channels];

this.obj = null;
Expand Down
6 changes: 6 additions & 0 deletions tests/unit/image.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ describe('Image', function () {
expect(jpeg.orientation).toBe(1);
});

test('RGB JPEG is parsed with DeviceRGB color space (regression)', () => {
const data = fs.readFileSync('./tests/images/bee.jpg');
const jpeg = new JPEG(data, 'test');
expect(jpeg.colorSpace).toBe('DeviceRGB');
});

describe('opacity', function () {
test('adds an ExtGState with the correct ca value', () => {
document.image('./tests/images/bee.png', 0, 0, { opacity: 0.5 });
Expand Down
Loading