revert clang tidy suppression - #4877
Merged
Merged
Conversation
aouxwoux
marked this pull request as ready for review
August 2, 2026 16:37
vitaut
approved these changes
Aug 5, 2026
Contributor
|
Merged, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
revert commit 619b3a5, which added the FMT_CLANG_ANALYZER special cases to the compile-string macro and apple file buffer initialization.
why
issue #4871 shows that the suppression removes one clang-tidy false positive but introduces another for FMT_COMPILE and ormatted_size. reverting the suppression restores the original code paths and matches the maintainer's suggested fix.
checks
fixes #4871