feat: alert on rollback when canary not ready - #1817
Open
rvanoo wants to merge 1 commit into
Open
Conversation
rvanoo
force-pushed
the
alert-on-canary-not-ready
branch
3 times, most recently
from
July 29, 2025 17:31
9d1b64b to
00892a3
Compare
aryan9600
approved these changes
Mar 7, 2026
aryan9600
left a comment
Member
There was a problem hiding this comment.
lgtm with a couple of nits - thank you! 🎖️
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1817 +/- ##
==========================================
+ Coverage 30.00% 30.19% +0.19%
==========================================
Files 287 288 +1
Lines 18467 18535 +68
==========================================
+ Hits 5541 5597 +56
- Misses 12195 12203 +8
- Partials 731 735 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Rob van Oostrum <rvanoo@gmail.com>
aryan9600
force-pushed
the
alert-on-canary-not-ready
branch
from
April 18, 2026 12:32
2fe5f85 to
9a1d374
Compare
|
Hello, since the PR is approved and passed all checks do you think it could be merged and shipped in the next release ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1816