Skip to content

feat: alert on rollback when canary not ready - #1817

Open
rvanoo wants to merge 1 commit into
fluxcd:mainfrom
rvanoo:alert-on-canary-not-ready
Open

feat: alert on rollback when canary not ready#1817
rvanoo wants to merge 1 commit into
fluxcd:mainfrom
rvanoo:alert-on-canary-not-ready

Conversation

@rvanoo

@rvanoo rvanoo commented Jul 29, 2025

Copy link
Copy Markdown

Implements #1816

@rvanoo
rvanoo force-pushed the alert-on-canary-not-ready branch 3 times, most recently from 9d1b64b to 00892a3 Compare July 29, 2025 17:31

@aryan9600 aryan9600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple of nits - thank you! 🎖️

Comment thread pkg/controller/scheduler.go Outdated
Comment thread pkg/controller/scheduler.go Outdated
@codecov-commenter

codecov-commenter commented Apr 18, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.19%. Comparing base (ceab3ec) to head (9a1d374).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/scheduler.go 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
+ Coverage   30.00%   30.19%   +0.19%     
==========================================
  Files         287      288       +1     
  Lines       18467    18535      +68     
==========================================
+ Hits         5541     5597      +56     
- Misses      12195    12203       +8     
- Partials      731      735       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Rob van Oostrum <rvanoo@gmail.com>
@aryan9600
aryan9600 force-pushed the alert-on-canary-not-ready branch from 2fe5f85 to 9a1d374 Compare April 18, 2026 12:32
@arthurchnsx

arthurchnsx commented Jul 22, 2026

Copy link
Copy Markdown

Hello, since the PR is approved and passed all checks do you think it could be merged and shipped in the next release ?
@aryan9600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants