Skip to content

Migrated plugin to Built-in Kotlin Gradle Plugin (KGP)#136

Open
drmirk wants to merge 4 commits into
fluttercommunity:mainfrom
drmirk:kgp_migration
Open

Migrated plugin to Built-in Kotlin Gradle Plugin (KGP)#136
drmirk wants to merge 4 commits into
fluttercommunity:mainfrom
drmirk:kgp_migration

Conversation

@drmirk

@drmirk drmirk commented May 30, 2026

Copy link
Copy Markdown

Flutter 3.44 is warning this plugin to migrate to Kotlin Gradle Plugin (KGP).

Comment thread wakelock_plus/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## [1.7.0]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't increment the changelog eagerly.

If I request changes, then this will get stale real fast.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, sorry! I tried to follow CONTRIBUTING.md and got confused on "bump version" in Create Pull Request section.

Comment thread wakelock_plus/pubspec.yaml Outdated
Plugin that allows you to keep the device screen awake, i.e. prevent the screen from sleeping on
Android, iOS, macOS, Windows, Linux, and web.
version: 1.6.1
version: 1.7.0

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@drmirk drmirk requested a review from diegotori May 30, 2026 21:05
@drmirk

drmirk commented May 31, 2026

Copy link
Copy Markdown
Author

I have reverted the version bump and rolled back the CHANGELOG.md.

@ubxty ubxty mentioned this pull request Jun 8, 2026
@drmirk

drmirk commented Jun 10, 2026

Copy link
Copy Markdown
Author
  • Updated the example to run in 3.38 by conditionally applying KGP only if AGP version is earlier than 9. So, now the example runs in 3.44 too.
  • Removed the unnecessary buildscript, which is fulfilled by builtin.
  • Tests run without error now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants