Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the search styling in _search.scss by setting the text color of the search input, adding a top margin to the completion box, and removing backgrounds for search results and cursor pages. The reviewer suggests appending !important to the new color property on the search input to ensure it consistently overrides styles across different browsers and themes.
Collaborator
|
Staged preview of the updated docs.flutter.dev site (updated for commit e083d61): https://flutter-docs-prod--docs-pr13488-fix-13336-4g95g227.web.app |
Collaborator
|
Staged preview of the updated flutter.dev site (updated for commit e083d61): https://flutter-dev-230821--www-pr13488-fix-13336-uszeye34.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overrides additional styles to improve styling of GSC results in dark mode with some smaller benefits in light mode as well.
Fixes #13336
Staged: https://flutter-docs-prod--docs-pr13488-fix-13336-4g95g227.web.app/search?q=testing