Remove legacy inspector documentation - #13233
Conversation
The legacy inspector has been replaced by the new inspector which is enabled by default since Flutter 3.29. This removes: - The legacy-inspector.md page - The 'Use legacy inspector' settings section from inspector.md - The legacy inspector entry from the sidenav Fixes flutter#9567
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the legacy Flutter inspector documentation, its associated section in the main inspector guide, and its entry in the side navigation. Feedback suggests further updating the inspector documentation to remove obsolete references to the "new" inspector and the option to disable it, as these distinctions are no longer necessary following the removal of the legacy version.
| However, it can be disabled from the [inspector settings dialog][]. | ||
|
|
||
| [inspector settings dialog]: #inspector-settings | ||
| [legacy inspector]: /tools/devtools/legacy-inspector |
There was a problem hiding this comment.
The removal of the legacy inspector link is correct. However, the introductory text in this section (lines 32-33) still refers to the inspector as "the new Flutter inspector" and mentions that it can be disabled. Since the legacy inspector has been removed, these distinctions are now obsolete and potentially confusing for users.
Consider updating the text to reflect that the current inspector is the standard one and removing the mention of disabling it to switch to the legacy version. For example:
## The Flutter inspector {:#new}
The Flutter inspector is enabled by default. It can be configured from the [inspector settings dialog][].There was a problem hiding this comment.
The removal of the legacy inspector link is correct. However, the introductory text in this section (lines 32-33) still refers to the inspector as "the new Flutter inspector" and mentions that it can be disabled. Since the legacy inspector has been removed, these distinctions are now obsolete and potentially confusing for users.
Consider updating the text to reflect that the current inspector is the standard one and removing the mention of disabling it to switch to the legacy version. For example:
## The Flutter inspector {:#new} The Flutter inspector is enabled by default. It can be configured from the [inspector settings dialog][].
Fixed, updated the heading and intro text to remove the 'new' distinction and the mention of disabling to switch to legacy inspector.
Since the legacy inspector has been removed, references to 'the new Flutter inspector' and the option to disable it are now obsolete. Updated heading and intro text accordingly.
|
Hi @crackedhandle - thank you for your contribution! However, we don't want to remove the documentation about the legacy inspector until after it has been removed from DevTools. Therefore I'm going to go ahead and close this. |
|
Thanks for the clarification @elliette! That makes complete sense - |
|
@crackedhandle if you are keen on re-opening this, the legacy inspector has been deleted, in flutter/devtools@46811ca, and we can now delete references to it. |
|
Thanks, Samuel! I'd be happy to continue this. I don't seem to have permission to reopen the PR from my side. Could you please reopen it? I'll update it as needed. |
3 participants
Fixes flutter/devtools#9567
Changes
src/content/tools/devtools/legacy-inspector.mdinspector.mdsrc/data/sidenav/default.ymlContext
The legacy inspector has been fully replaced by the new inspector,
which is enabled by default since Flutter 3.29. The legacy-inspector
page had a warning banner saying it would be removed in a future release —
this PR removes it now.