Skip to content

[tool] Support promoting to 1.0 in batch releases#12262

Open
stuartmorgan-g wants to merge 3 commits into
flutter:mainfrom
stuartmorgan-g:tool-batch-promote-to-one-oh
Open

[tool] Support promoting to 1.0 in batch releases#12262
stuartmorgan-g wants to merge 3 commits into
flutter:mainfrom
stuartmorgan-g:tool-batch-promote-to-one-oh

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Adds a new "promote" keyword recognized by the batch release changelog processor, which allows for a pre-1.0 package to be promoted to 1.0 using the usual batch release process.

Adds a new "promote" keyword recognized by the batch release changelog
processor, which allows for a pre-1.0 package to be promoted to 1.0
using the usual batch release process.
@stuartmorgan-g
stuartmorgan-g requested a review from justinmc July 21, 2026 18:22
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 21, 2026

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a promote option to the VersionChange enum, enabling pre-1.0 packages to be promoted to version 1.0.0. It adds validation to ensure promote is only applied to pre-1.0 packages, throwing an error otherwise, and includes corresponding unit tests. Feedback suggests removing redundant setup code in the new tests, as createTestPackage() already creates the pending_changelogs directory and writes the default changelog header.

Comment thread script/tool/test/branches_for_batch_release_command_test.dart Outdated
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2026
@auto-submit

auto-submit Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12262, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2026
@auto-submit

auto-submit Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12262, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants