Skip to content

[cupertino_ui] Publish pre-release 0.0.2#12251

Merged
auto-submit[bot] merged 9 commits into
mainfrom
publish_to
Jul 20, 2026
Merged

[cupertino_ui] Publish pre-release 0.0.2#12251
auto-submit[bot] merged 9 commits into
mainfrom
publish_to

Conversation

@justinmc

@justinmc justinmc commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This PR attempts to enable the batch release process for cupertino_ui.

@justinmc
justinmc requested a review from Piinks July 20, 2026 17:58
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 20, 2026
@justinmc justinmc self-assigned this Jul 20, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui p: material_ui labels Jul 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the publish_to: none restriction from the pubspec.yaml files of both cupertino_ui and material_ui packages to prepare them for publication. The review feedback notes that publishing will fail due to unresolved path dependencies between the two packages, which must be addressed before publishing to pub.dev.

name: material_ui
description: The official Flutter Material UI Library, implementing Google's Material Design design system.
version: 0.0.2
publish_to: none

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Attempting to publish material_ui will fail because it contains a path dependency on cupertino_ui under dependencies (line 18 of pubspec.yaml). Packages published to pub.dev cannot have path dependencies in their dependencies section. You must first publish cupertino_ui to pub.dev, and then update material_ui to use that hosted version before removing publish_to: none.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true! I plan to do this in another PR after cupertino_ui is published.

name: cupertino_ui
description: The official Flutter Cupertino Design Library, implementing the iOS design system.
version: 0.0.2
publish_to: none

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Attempting to publish cupertino_ui will fail because it contains a path dependency on material_ui under dev_dependencies (line 32 of pubspec.yaml). Packages published to pub.dev cannot have path dependencies in their dev_dependencies section. Since material_ui also depends on cupertino_ui, this creates a circular dependency. You will need to temporarily remove or resolve this path dependency to publish cupertino_ui first.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. Is this true?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping this is not true and I can fix it after publishing.

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Is there a reason this is being pre-landed, rather than as part of the PR that actually does the publishing?

This will mean that if we try to land any batch change that touches these packages, it'll cause publishing issues.

@justinmc

Copy link
Copy Markdown
Contributor Author

Talked offline, I'm going to try to modify this PR to do the release via the automated batch release process if possible.

@justinmc justinmc changed the title [material_ui, cupertino_ui] Remove publish_to none now that we are going to publish [cupertino_ui] Publish pre-release 0.0.2 Jul 20, 2026

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the current version (with the caveat that I've not actually used the batch release mechanism myself).

Comment thread packages/cupertino_ui/pubspec.yaml Outdated
@@ -1,7 +1,6 @@
name: cupertino_ui
description: The official Flutter Cupertino Design Library, implementing the iOS design system.
version: 0.0.2

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need to make this 0.01 since that's the currently published version.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I was just seeing this error in CI and I thought I had to add 0.0.2 to the changelog, but you must be right, the correct thing to do is to make this 0.0.1.

justinmc added 4 commits July 20, 2026 12:18
Probably due to enabling the batch release process now, shouldn't happen
in future PRs if I understand correctly. Because at this point I would
not know that this PR will necessarily be 0.0.2 (another PR could land
first and claim that version).
CI isn't happy about me making manual changes there. Let's revert them
and let the batch release process bump the package to 0.0.3 instead. Pub
never got version 0.0.2 but I think that's ok.
@justinmc

Copy link
Copy Markdown
Contributor Author

Waiting on #12252

auto-submit Bot pushed a commit that referenced this pull request Jul 20, 2026
cupertino_ui has had publishing turned off, but we're going to turn on the batch release process soon. This PR adjusts the pubspec version and Changelog to match what's on Pub, so that the batch release process can take over from there.

The version was originally bumped manually in #11649.

PR #12251 will come after this one and will enable the batch release process.
@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2026
@auto-submit
auto-submit Bot merged commit 8260a1e into main Jul 20, 2026
13 checks passed
@auto-submit
auto-submit Bot deleted the publish_to branch July 20, 2026 22:45
workflow_dispatch:
schedule:
# Run every Monday at 8:00 AM. Update cron as needed.
- cron: "0 8 * * 1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this means this won't go out until next Monday?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to manually trigger it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: cupertino_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants