[cupertino_ui] Publish pre-release 0.0.2#12251
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the publish_to: none restriction from the pubspec.yaml files of both cupertino_ui and material_ui packages to prepare them for publication. The review feedback notes that publishing will fail due to unresolved path dependencies between the two packages, which must be addressed before publishing to pub.dev.
| name: material_ui | ||
| description: The official Flutter Material UI Library, implementing Google's Material Design design system. | ||
| version: 0.0.2 | ||
| publish_to: none |
There was a problem hiding this comment.
Attempting to publish material_ui will fail because it contains a path dependency on cupertino_ui under dependencies (line 18 of pubspec.yaml). Packages published to pub.dev cannot have path dependencies in their dependencies section. You must first publish cupertino_ui to pub.dev, and then update material_ui to use that hosted version before removing publish_to: none.
There was a problem hiding this comment.
This is true! I plan to do this in another PR after cupertino_ui is published.
| name: cupertino_ui | ||
| description: The official Flutter Cupertino Design Library, implementing the iOS design system. | ||
| version: 0.0.2 | ||
| publish_to: none |
There was a problem hiding this comment.
Attempting to publish cupertino_ui will fail because it contains a path dependency on material_ui under dev_dependencies (line 32 of pubspec.yaml). Packages published to pub.dev cannot have path dependencies in their dev_dependencies section. Since material_ui also depends on cupertino_ui, this creates a circular dependency. You will need to temporarily remove or resolve this path dependency to publish cupertino_ui first.
There was a problem hiding this comment.
I'm hoping this is not true and I can fix it after publishing.
|
Is there a reason this is being pre-landed, rather than as part of the PR that actually does the publishing? This will mean that if we try to land any batch change that touches these packages, it'll cause publishing issues. |
|
Talked offline, I'm going to try to modify this PR to do the release via the automated batch release process if possible. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM other than the current version (with the caveat that I've not actually used the batch release mechanism myself).
| @@ -1,7 +1,6 @@ | |||
| name: cupertino_ui | |||
| description: The official Flutter Cupertino Design Library, implementing the iOS design system. | |||
| version: 0.0.2 | |||
There was a problem hiding this comment.
I believe you need to make this 0.01 since that's the currently published version.
There was a problem hiding this comment.
Ah I was just seeing this error in CI and I thought I had to add 0.0.2 to the changelog, but you must be right, the correct thing to do is to make this 0.0.1.
Probably due to enabling the batch release process now, shouldn't happen in future PRs if I understand correctly. Because at this point I would not know that this PR will necessarily be 0.0.2 (another PR could land first and claim that version).
CI isn't happy about me making manual changes there. Let's revert them and let the batch release process bump the package to 0.0.3 instead. Pub never got version 0.0.2 but I think that's ok.
|
Waiting on #12252 |
cupertino_ui has had publishing turned off, but we're going to turn on the batch release process soon. This PR adjusts the pubspec version and Changelog to match what's on Pub, so that the batch release process can take over from there. The version was originally bumped manually in #11649. PR #12251 will come after this one and will enable the batch release process.
| workflow_dispatch: | ||
| schedule: | ||
| # Run every Monday at 8:00 AM. Update cron as needed. | ||
| - cron: "0 8 * * 1" |
There was a problem hiding this comment.
I think this means this won't go out until next Monday?
There was a problem hiding this comment.
Any way to manually trigger it?
There was a problem hiding this comment.
Yes: https://github.com/flutter/packages/actions/workflows/cupertino_ui_batch.yml
I'll try it after postsubmits pass.
This PR attempts to enable the batch release process for cupertino_ui.