[webview] Add new method for cross plugin webview access by fuzzybinary · Pull Request #11714 · flutter/packages

fuzzybinary · 2026-05-14T19:50:49Z

A new way of supporting cross plugin communication is coming in Flutter 3.44 which allows for access to plugin published values through the FlutterPluginBinding on Android and the FlutterPluginRegistry on iOS. Update native WebView access to support these new methods and deprecate the old methods.

refs: flutter/flutter#121527 flutter/flutter#182753

Pre-Review Checklist

gemini-code-assist

Code Review

This pull request introduces new methods to access native WebView (Android) and WKWebView (iOS/macOS) instances using FlutterPluginBinding and FlutterPluginRegistrar, respectively, while deprecating the previous engine and registry-based approaches. The changes include updated unit tests and a minimum Flutter version bump to 3.44.0 for both packages. Review feedback identifies a pluralization inconsistency in the wkwebview changelog and an unnecessary downgrade of the Dart SDK constraint in its pubspec.yaml.

A new way of supporting cross plugin communication is coming in Flutter 3.44 which allows for access to plugin published values through the `FlutterPluginBinding` on Android and the `FlutterPluginRegistry` on iOS. Update native WebView access to support these new methods and deprecate the old methods. refs: flutter/flutter#121527 flutter/flutter#182753 # Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml

bparrishMines · 2026-05-20T05:02:30Z

 environment:
  sdk: ^3.10.0
-  flutter: ">=3.38.0"
+  flutter: ">=3.44.0"


@stuartmorgan-g Does this PR need to wait until we bump all the plugins in the repo to 3.44? This isn't fixing a bug, so I don't think it is an exemption to support n-2 stable version.

We don't require supporting N-2, we just don't allow supporting things older than N-2. We only require supporting stable.

This will need wait until Flutter master rolls to a version that reports being newer than a 3.44 pre-release though so that the resolver works (the usual problem we have with master right after a release).

stuartmorgan-g · 2026-05-20T17:42:11Z

+    final WebViewFlutterPlugin webViewPlugin =
+        (WebViewFlutterPlugin) binding.getPlugin(WebViewFlutterPlugin.class);
+
+    if (webViewPlugin != null && webViewPlugin.getInstanceManager() != null) {


Everything from here on can be extracted to a private helper instead of duplicated.

stuartmorgan-g · 2026-05-20T17:42:55Z

+version: 4.13.0

 environment:
  sdk: ^3.9.0


We require that the Dart and Flutter versions align in our packages, so this needs to be updated as well.

stuartmorgan-g · 2026-05-21T16:09:01Z

We've rolled 3.44 stable into the repo, and master has been fixed upstream to report 3.45.0-*, so if you merge in main when addressing my comments, CI should pass.

# Conflicts: # packages/webview_flutter/webview_flutter_android/CHANGELOG.md # packages/webview_flutter/webview_flutter_android/pubspec.yaml

fuzzybinary · 2026-05-21T20:21:31Z

😬 When updating this it looks like there's a secondary problem. While valuePublished(byPlugin:) was added to FlutterPluginRegistrar on iOS, I didn't add it on macOS, and the WKWebView plugin is "Darwin" code, meaning its meant to run on both macOS and iOS. I don't know how it slipped through my initial testing but maybe something changed?

Thoughts on the correct solution here? I can go in and add the valuePublishedByPlugin method on the macOS FlutterPluginRegistrar, but that would mean trying to get that into a patch release of 3.44,

I could mark the external method as iOS only for time being, then add the required method to macOS later...

Suggestions @stuartmorgan-g ?

Also question about the CHANGELOG changes for Android. Can I have both ## NEXT for the next patch bump and a header for the next minor bump, or should I have combined them?

stuartmorgan-g · 2026-05-21T20:29:01Z

I could mark the external method as iOS only for time being, then add the required method to macOS later...

That's the simplest path forward; the pressing use case I'm aware of for this API is on iOS, so fixing it there faster is worth the temporary mismatch. The ifdef should have a TODO comment explaining why it's ifdef'd out, and linking to an issue filed to track adding the API to the macOS engine.

Also question about the CHANGELOG changes for Android. Can I have both ## NEXT for the next patch bump and a header for the next minor bump, or should I have combined them?

They need to be combined.

stuartmorgan-g

LGTM

stuartmorgan-g · 2026-05-22T17:58:40Z

Looks like the min Dart SDK bump picked up some minor analyzer issues that will need to be fixed (due to a new Dart feature being available).

fuzzybinary · 2026-05-28T15:08:15Z

Linux repo_checks is complaining about format changes but I'm not seeing any changes when I run the formatter. Is CICD using a different version?

stuartmorgan-g · 2026-05-28T15:23:13Z

Are you on a very recent master? There's apparently a formatter behavior change that's not target-SDK-version gated like most Dart formatter changes have been, and it hasn't rolled into this repo yet, so you may be getting a different local format.

To make sure you match, you can temporarily sync your local Flutter to this version and then format.)

fuzzybinary · 2026-05-28T15:36:22Z

I was actually on Flutter Stable (3.44). Syncing to that commit and reformatting did make some changes, so hopefully it's now correct.

stuartmorgan-g

LGTM!

auto-submit · 2026-05-28T17:01:36Z

autosubmit label was removed for flutter/packages/11714, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

stuartmorgan-g · 2026-05-28T17:05:00Z

Oops, I thought @bparrishMines had already approved this.

github-actions Bot added platform-android platform-ios platform-macos p: webview_flutter labels May 14, 2026

gemini-code-assist Bot reviewed May 14, 2026

View reviewed changes

Comment thread packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md Outdated

Comment thread packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml Outdated

fuzzybinary force-pushed the webview-new-publish-api branch from 796dc17 to c4d49c6 Compare May 14, 2026 20:21

stuartmorgan-g requested review from bparrishMines and stuartmorgan-g May 19, 2026 18:26

bparrishMines added the CICD Run CI/CD label May 20, 2026

bparrishMines reviewed May 20, 2026

View reviewed changes

stuartmorgan-g requested changes May 20, 2026

View reviewed changes

fuzzybinary added 2 commits May 21, 2026 15:58

Merge branch 'main' into webview-new-publish-api

5114624

# Conflicts: # packages/webview_flutter/webview_flutter_android/CHANGELOG.md # packages/webview_flutter/webview_flutter_android/pubspec.yaml

[webview] Use helper methods webview access from plugin

6496537

github-actions Bot removed the CICD Run CI/CD label May 21, 2026

fuzzybinary mentioned this pull request May 21, 2026

[macOS] Support FlutterPluginRegistrar.valuePublished(byPlugin:) flutter/flutter#186911

Open

[webview] Exclude macOS from new plugin communication.

7cd9914

fuzzybinary requested a review from stuartmorgan-g May 21, 2026 21:04

stuartmorgan-g approved these changes May 22, 2026

View reviewed changes

stuartmorgan-g requested a review from bparrishMines May 22, 2026 17:34

stuartmorgan-g added the CICD Run CI/CD label May 22, 2026

[webview] Fix analyzer errors from Dart SDK bump

cb2ee57

github-actions Bot removed the CICD Run CI/CD label May 27, 2026

stuartmorgan-g added the CICD Run CI/CD label May 27, 2026

Fix formatting

8f474a2

github-actions Bot removed the CICD Run CI/CD label May 28, 2026

stuartmorgan-g added the CICD Run CI/CD label May 28, 2026

stuartmorgan-g approved these changes May 28, 2026

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2026

Conversation

fuzzybinary commented May 14, 2026

Pre-Review Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

bparrishMines May 20, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 20, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 20, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 20, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented May 21, 2026

Uh oh!

fuzzybinary commented May 21, 2026

Uh oh!

stuartmorgan-g commented May 21, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented May 22, 2026

Uh oh!

fuzzybinary commented May 28, 2026

Uh oh!

stuartmorgan-g commented May 28, 2026

Uh oh!

fuzzybinary commented May 28, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented May 28, 2026

Uh oh!

stuartmorgan-g commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants