Skip to content

Prevent GC of value during async eval #9885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srawlins wants to merge 4 commits into
base: master
Choose a base branch
from
+21 −3
Open

Prevent GC of value during async eval #9885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7f8265
Prevent GC of value during async eval
srawlins Jul 9, 2026
ba981d3
fix
srawlins Jul 11, 2026
c0b3c8f
note
srawlins Jul 13, 2026
24bd17c
while-loop
srawlins Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ TODO: Remove this section if there are not any updates.

## Debugger updates

TODO: Remove this section if there are not any updates.
* Prevent values from being garbage-collected, while being evaluated.

@kenzieschmoll kenzieschmoll Jul 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add link to PR


## Network profiler updates

Expand Down
1 change: 1 addition & 0 deletions packages/devtools_app_shared/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ found in the LICENSE file or at https://developers.google.com/open-source/licens
## 0.5.2-wip
* Fix a `RangeError` thrown by `SplitPane` when the number of children
changes between rebuilds.
* Fix garbage collection issues with the result list in `asyncEval` on both native VM and web.
* The minimum Dart SDK version is bumped to 3.11.0.
* The minimum Flutter SDK version is bumped to 3.41.0.

Expand Down
21 changes: 19 additions & 2 deletions packages/devtools_app_shared/lib/src/service/eval_on_dart_library.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
// This code is directly based on src/io/flutter/inspector/EvalOnDartLibrary.java
// If you add a method to this class you should also add it to EvalOnDartLibrary.java
import 'dart:async';
import 'dart:core' hide Error;
import 'dart:core' as core;
import 'dart:core' hide Error;
import 'dart:math';

import 'package:flutter/foundation.dart';
import 'package:logging/logging.dart';
import 'package:meta/meta.dart';
import 'package:vm_service/vm_service.dart' hide Error;
import 'package:vm_service/vm_service.dart' as vm_service;
import 'package:vm_service/vm_service.dart' hide Error;

import '../utils/auto_dispose.dart';
import 'service_manager.dart';
Expand Down Expand Up @@ -429,6 +429,22 @@ class EvalOnDartLibrary extends DisposableController
await safeEval(
'() async {'
' final reader = widgetInspectorService.toObject("$readerId", "$readerGroup") as List;'
' /* Keep a strong reference to `reader` in the target app to prevent it'
' from being garbage collected by Chrome/VM before the future resolves.'
' Without this, the reader is only weakly referenced by the inspector'
' service and is aggressively GCed, causing a TypeError/TimeoutException'
' or failing the assertion that the retrieved result length is 1 or 2.'
' We use Future.delayed in a loop instead of Timer because Future is in'
' dart:core and guaranteed to be resolved without requiring dart:async. */'
' bool isDone = false;'
' () async {'
' int bufferTicks = 0;'
' /* Stop pinning after a 1-second buffer when the future has completed. */'
' while (!isDone && ++bufferTicks <=20) {'
' final _ = reader;'
' await Future.delayed(const Duration(milliseconds: 50));'
' }'
' }();'
' try {'
// Cast as dynamic so that it is possible to await Future<void>
' dynamic result = ($expression) as dynamic;'
Expand All @@ -437,6 +453,7 @@ class EvalOnDartLibrary extends DisposableController
' reader.add(err);'
' reader.add(stack);'
' } finally {'
' isDone = true;'
' postEvent("future_completed", {"future_id": $futureId, "client_id": $_clientId});'
' }'
'}()',
Expand Down
Loading