[video_player_avplay] Update the way to call the SetDisplay API#1018
Open
gin7773 wants to merge 2 commits intoflutter-tizen:masterfrom
Open
[video_player_avplay] Update the way to call the SetDisplay API#1018gin7773 wants to merge 2 commits intoflutter-tizen:masterfrom
gin7773 wants to merge 2 commits intoflutter-tizen:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the video_player_avplay package to version 0.8.10 and modifies the SetDisplay API call in plus_player.cc to use hardcoded 0, 0 coordinates. Feedback suggests removing the now-unused x and y variables to adhere to the Google C++ Style Guide.
| } | ||
| bool ret = ::SetDisplay(player_, plusplayer::DisplayType::kOverlay, | ||
| resource_id, x, y, width, height); | ||
| resource_id, 0, 0, width, height); |
Contributor
There was a problem hiding this comment.
By hardcoding 0, 0 in the SetDisplay call, the variables x and y (declared and assigned on lines 434-436) are now unused. To maintain code quality and adhere to the Google C++ Style Guide, please remove these unused variables and update the ecore_wl2_window_geometry_get call (e.g., by passing nullptr for the unused coordinates if the API supports it).
References
- C++ code should follow the Google C++ Style Guide, which encourages clean code and avoiding unused variables. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change:
SetDisplayAPI.The coordinates (x, y) of
SetDisplayare relative to the offset of the Window. The position ofSetDisplayshould overlap with the Window, so the offset value should always be 0.