feat: SPM migration for all packages + support simulator#890
Open
pumano wants to merge 2 commits into
Open
Conversation
Collaborator
|
@pumano : did you test running the example app and makeing sure the detection works? If yes then list the ones you have tested on an actual device. |
Author
|
@fbernaly I push second commit and looks like I fix it! app launched successfully!! Check it out plz. I don't have real iphone device right now, can't test. If you can help with it - will be good |
Collaborator
|
@pumano : not only launching the app but testing each of the features, with these migration work I have seen a lot of runtime errors that do not happen with cocoapods, that is why I have not released this SPM migration until all the features run with no runtime crashes |
Author
|
OK I will try to find real device tomorrow and debug it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fbernaly I found that fork https://github.com/mdata-group/google-mlkit-swiftpm fix simulator problem, but some things linked twice results to Error (Xcode): 115 duplicate symbols
There are 115 duplicate symbols because MLKitCommon gets linked multiple times.
google_mlkit_commonsdepends onMLKitBarcodeScanning(which includesMLKitCommon), and other packages likebarcode_scanningalso depend onMLKitBarcodeScanningdirectly — causingMLKitCommonto be linked twice.duplicate symbol 'MLKITx_strings::CleanStringLineEndings(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>*, bool)' in: duplicate symbol 'MLKITx_strings::ShellEscape(MLKITx_absl::string_view)' in: duplicate symbol 'MLKITx_strings::EightBase32DigitsToFiveBytes(char const*, unsigned char*)' in: duplicate symbol 'MLKITx_absl::WebSafeBase64Unescape(char const*, long, char*, long)' in: duplicate symbol 'MLKITx_strings::ByteStringToAscii(MLKITx_absl::string_view, long, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>*)' in: duplicate symbol 'MLKITx_absl::base_internal::delete_hooks_' in: duplicate symbol 'MLKITx_absl::base_internal::MallocHook::AddNewHook(void (*)(MLKITx_tcmalloc::MallocHook::NewInfo const&))' in: duplicate symbol 'MLKITx_absl::base_internal::MallocHook::AddMremapHook(void (*)(void const*, void const*, unsigned long, unsigned long, int, void const*))' in: duplicate symbol 'MLKITx_strings::TenHexDigitsToEightBas…Could you check it? Maybe you can fix it