Skip to content

Proposal: winston@3 transport - #23

Open
lyykfi wants to merge 2 commits into
fluent:masterfrom
lyykfi:pr-winston-transport
Open

lyykfi wants to merge 2 commits into
fluent:masterfrom
lyykfi:pr-winston-transport

Conversation

@lyykfi

@lyykfi lyykfi commented Oct 7, 2021

Copy link
Copy Markdown

No description provided.

@jamiees2

jamiees2 commented Oct 7, 2021

Copy link
Copy Markdown
Collaborator

This looks great :) but I'm wondering if we should try to publish this as a separate package, e.g something like @fluent-org/winston-transport.

I think it'd be nice to maintain in the same repository, but having a separate package allows us to avoid adding winston-transport as a dependency, and having it as a peerDependency isn't a great solution either IMO.

What do you think?

@lyykfi

lyykfi commented Oct 7, 2021

Copy link
Copy Markdown
Author

I totally agree and that is fair point. :-)

How could we do that? Are you going to create another repo?

@jamiees2

jamiees2 commented Oct 7, 2021

Copy link
Copy Markdown
Collaborator

I think it'd be nice to maintain them alongside each other since the projects are still very closely related, but I'm not sure, I'll look into some approaches other projects take :)

@brunobastosg

Copy link
Copy Markdown

Any news on this? Will it be published as a separate package?

For now I'll be copying @lyykfi 's code to my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants