Skip to content

config: config_format: address wrongly specified parameter on service section - #12314

Draft
cosmo0920 wants to merge 3 commits into
masterfrom
cosmo0920-address-wrongly-specified-parameter-on-service-section
Draft

config: config_format: address wrongly specified parameter on service section#12314
cosmo0920 wants to merge 3 commits into
masterfrom
cosmo0920-address-wrongly-specified-parameter-on-service-section

Conversation

@cosmo0920

Copy link
Copy Markdown
Contributor
  • Unknown [SERVICE] properties now warn while preserving success behavior.
  • Unknown configuration sections now warn and are ignored.
  • Section names require exact case-insensitive matches, so [SERVIC] is correctly rejected.
  • Added classic/YAML and compatibility regression tests in config_service.c.

Verification:

  • ctest --test-dir build -R '^flb-it-config_(service|format|format_fluentbit|format_yaml)$' --output-on-failure
    • 4/4 passed.
  • Classic, YAML, and [SERVIC] executable --dry-run checks succeeded with the expected warnings.
  • Memory checker: not run; Valgrind and macOS Leaks are unavailable on Windows.
  • Working tree is clean.

Closes #8819


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ed78396-1c1b-4be4-99f3-d14ee8d92b34

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
…ction

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920
cosmo0920 force-pushed the cosmo0920-address-wrongly-specified-parameter-on-service-section branch from 9376074 to 1b115ce Compare August 20, 2026 11:34
@cosmo0920 cosmo0920 changed the title config: config_format: address wrongly specified parameter on service section config: config_format: address wrongly specified parameter on service section Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fluent Bit silently ignores wrong parameter names in the service section

1 participant