in_etw: Add a documentation for Event Tracing for Windows input plugin#2618
in_etw: Add a documentation for Event Tracing for Windows input plugin#2618cosmo0920 wants to merge 2 commits into
Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughThis PR adds documentation for the Windows-only Event Tracing for Windows input plugin, including configuration, emitted fields, examples, and permissions guidance. It also adds navigation and redirect entries for the new page. ChangesETW Documentation Addition
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/inputs/event-tracing-windows.md`:
- Line 35: Clarify the provider identity validation in the event tracing Windows
docs: the check should compare the resolved provider GUID against the configured
provider_guid, not the provider name. Update the wording around the provider
session rules so it explicitly says provider_guid, provider_name, or both may be
set, and if both are set the resolved GUID must match the configured GUID; use
the provider/session terminology consistently in this section.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c1edbe88-8e57-4906-a1df-b70b4cda3510
📒 Files selected for processing (3)
.gitbook.yamlSUMMARY.mdpipeline/inputs/event-tracing-windows.md
Clean up Vale suggestions on the new Event Tracing for Windows input
plugin doc:
- Use sentence-style capitalization for the page title and sync
matching SUMMARY.md navigation entry.
- Wrap bare "GUID" references in backticks so the FluentBit.Acronyms
rule no longer flags them
Applies to #2618
Signed-off-by: Eric D. Schabell <eric@schabell.org>
Clean up Vale suggestions on the new Event Tracing for Windows input
plugin doc:
- Use sentence-style capitalization for the page title and sync
matching SUMMARY.md navigation entry.
- Wrap bare "GUID" references in backticks so the FluentBit.Acronyms
rule no longer flags them and table alignments
Applies to #2618
Signed-off-by: Eric D. Schabell <eric@schabell.org>
17651ee to
725db94
Compare
Clean up Vale suggestions on the new Event Tracing for Windows input
plugin doc:
- Use sentence-style capitalization for the page title and sync
matching SUMMARY.md navigation entry.
- Wrap bare "GUID" references in backticks so the FluentBit.Acronyms
rule no longer flags them and table alignments
- Classic config keys → Title_Case
Applies to #2618
Signed-off-by: Eric D. Schabell <eric@schabell.org>
725db94 to
79b7fb4
Compare
eschabell
left a comment
There was a problem hiding this comment.
@cosmo0920 fixed a bunch of formatting issues, now just waiting on code PR merging. Thanks for the docs PR!
Corresponding PR is fluent/fluent-bit#12072.
Summary by CodeRabbit