Add docs for resource out otel#2405
Conversation
Signed-off-by: BOSLET, CORY <cb645j+ATT@att.com>
|
Warning Review limit reached
More reviews will be available in 12 minutes and 56 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new configuration option ChangesOpenTelemetry Output Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pipeline/outputs/opentelemetry.md`:
- Line 41: Update the param table row for logs_resource_attributes_message_key
so its description clearly states that this key names a message-field whose
value will be promoted into the OpenTelemetry Resource attributes (distinct from
logs_resource_metadata_key which maps metadata fields); replace the vague text
with an explicit phrase like “Specify the message field key whose value will be
promoted into the Resource attributes.”
- Line 139: The fluent-bit.conf example includes a new option that is missing
from the fluent-bit.yaml example; update the YAML example in
pipeline/outputs/opentelemetry.md (the fluent-bit.yaml code block around the
current examples) to include the equivalent key/value entry so both examples
demonstrate the same feature set—locate the fluent-bit.conf block to see the
exact option name and value, then add the matching YAML mapping/key under the
fluent-bit.yaml section with the same semantic setting and a brief inline
comment mirroring the conf example.
- Around line 189-190: Remove the invalid Fluent Bit OpenTelemetry output option
`logs_resource_attributes_message_key` and instead demonstrate configuring
resource attributes via a processors pipeline using the `opentelemetry_envelope`
processor with `content_modifier`; specifically, delete the two lines containing
`logs_resource_attributes_message_key application_id` and
`logs_resource_attributes_message_key service_name` and replace (or document)
using an `opentelemetry_envelope` processor block with `content_modifier` rules
to add/rename resource attributes for logs as per the OpenTelemetry processor
usage.
|
@cb645j a few ai review issues to be solved please, see above comment. |
|
@cb645j thanks for the updates, but it's now raised conflicts that I need you to resolve before I can review? |
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
@cb645j resolved the conflict, can you verify that your updates are intact? |
…tes_message_key description
- Replace vague "Specify a Resource key" with an explicit description
stating the param names a message field key whose value is promoted
into OpenTelemetry Resource attributes
Applies to fluent#2405
Signed-off-by: Eric D. Schabell <eric@schabell.org>
5217d80 to
536da50
Compare
|
@cb645j cleaned up all the issues with PR. |
…message_key to YAML example
- Add logs_resource_attributes_message_key list entries (application_id,
service_name) to the fluent-bit.yaml code block to match the existing
fluent-bit.conf example
Applies to fluent#2405
Signed-off-by: Eric D. Schabell <eric@schabell.org>
Summary by CodeRabbit
New Features
Documentation