Skip to content

update out_pgsql add configurable field Daemon#2118

Open
TomlinfreeGit wants to merge 3 commits into
fluent:masterfrom
TomlinfreeGit:feature/daemon-out-pgsql
Open

update out_pgsql add configurable field Daemon#2118
TomlinfreeGit wants to merge 3 commits into
fluent:masterfrom
TomlinfreeGit:feature/daemon-out-pgsql

Conversation

@TomlinfreeGit
Copy link
Copy Markdown

@TomlinfreeGit TomlinfreeGit commented Oct 28, 2025

update out_pgsql plugin: add a configurable parameter to support run this plugin in a daemon mode.
if in daemon mode, configuration error of out_pgsql will not cause fluentbit crash or exit.

code Merge Request link as follows:
fluent/fluent-bit#7215

Summary by CodeRabbit

  • Documentation
    • Updated PostgreSQL output plugin documentation with a new daemon configuration parameter (default: false).
    • Improved documentation formatting and spacing for better readability.

Review Change Stack

@TomlinfreeGit TomlinfreeGit requested review from a team as code owners October 28, 2025 08:45
…yao.lin@siemens.com>

Signed-off-by: Tom <yao.lin@siemens.com>
@TomlinfreeGit TomlinfreeGit force-pushed the feature/daemon-out-pgsql branch from 0f35c07 to cd222d4 Compare October 28, 2025 08:46
Signed-off-by: Lynette  Miles <6818907+esmerel@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cosmo0920
Copy link
Copy Markdown
Contributor

To merge this PR, we need to process reviewing process on fluent-bit repo at first.
I added waiting-on-code-merge label to distinguish that it's not ready to merge this.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-requested a review as a code owner May 26, 2026 06:47
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

📝 Walkthrough

Walkthrough

The PostgreSQL output plugin documentation is updated to document a new daemon configuration parameter in the configuration parameters table with a default value of false. The document spacing is also adjusted around section breaks for clarity.

Changes

PostgreSQL daemon parameter documentation

Layer / File(s) Summary
daemon parameter documentation and spacing adjustment
pipeline/outputs/postgresql.md
Documentation for the daemon parameter is added to the PostgreSQL configuration parameters table with default false, and spacing is adjusted around the section break following the worker-connection note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • fluent/fluent-bit-docs#2542: Both PRs modify pipeline/outputs/postgresql.md to update PostgreSQL plugin configuration docs by adjusting/removing legacy async/pooling-related settings and updating parameter tables around worker/connection notes.

Suggested reviewers

  • eschabell

Poem

🐰 A daemon awakens in PostgreSQL's night,
Configuration documented shining bright,
Spacing adjusted, tables aligned with care,
Fluent-bit docs improve everywhere! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly summarizes the main change: adding a configurable Daemon field to the out_pgsql plugin documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell eschabell added waiting-on-review Waiting on a review from mainteners and removed gitbook-issues waiting-on-review Waiting on a review from mainteners labels May 26, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pipeline/outputs/postgresql.md`:
- Line 62: Update the wording for the `daemon` parameter description: replace
the current phrase "Set to `true` if you want run this plugin instance in daemon
mode." with clearer grammar and intent such as "Set to `true` to run this plugin
instance in daemon mode." Ensure the change is applied to the table row for the
`daemon` parameter.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dbbaa66e-ee0a-43b7-b941-71a58b4ab558

📥 Commits

Reviewing files that changed from the base of the PR and between 6b742a6 and d4c00f2.

📒 Files selected for processing (1)
  • pipeline/outputs/postgresql.md

Comment thread pipeline/outputs/postgresql.md
Copy link
Copy Markdown
Collaborator

@eschabell eschabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomlinfreeGit thanks for the docs PR, good to go and just waiting for the corresponding code PR to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants