update out_pgsql add configurable field Daemon#2118
Conversation
…yao.lin@siemens.com> Signed-off-by: Tom <yao.lin@siemens.com>
0f35c07 to
cd222d4
Compare
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
To merge this PR, we need to process reviewing process on fluent-bit repo at first. |
Signed-off-by: Eric D. Schabell <eric@schabell.org>
📝 WalkthroughWalkthroughThe PostgreSQL output plugin documentation is updated to document a new ChangesPostgreSQL daemon parameter documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/outputs/postgresql.md`:
- Line 62: Update the wording for the `daemon` parameter description: replace
the current phrase "Set to `true` if you want run this plugin instance in daemon
mode." with clearer grammar and intent such as "Set to `true` to run this plugin
instance in daemon mode." Ensure the change is applied to the table row for the
`daemon` parameter.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: dbbaa66e-ee0a-43b7-b941-71a58b4ab558
📒 Files selected for processing (1)
pipeline/outputs/postgresql.md
eschabell
left a comment
There was a problem hiding this comment.
@TomlinfreeGit thanks for the docs PR, good to go and just waiting for the corresponding code PR to merge.
update out_pgsql plugin: add a configurable parameter to support run this plugin in a daemon mode.
if in daemon mode, configuration error of out_pgsql will not cause fluentbit crash or exit.
code Merge Request link as follows:
fluent/fluent-bit#7215
Summary by CodeRabbit
daemonconfiguration parameter (default:false).