packaging: add opensuse and sles#2103
Conversation
Signed-off-by: Dan Illescas <daniel.illescas@hpe.com>
esmerel
left a comment
esmerel
left a comment
There was a problem hiding this comment.
I made some consistency suggestions which will fix some of the vale warnings.
I also updated the vale test so that SUSE/SLES shouldn't give warnings anymore, but those are in master so this branch is still going to have the warnings but won't after merging (or if it's rebased).
Signed-off-by: Dan Illescas <daniel.illescas@hpe.com>
|
@esmerel thanks for your review and suggestions. i just pushed changes for |
cosmo0920
left a comment
cosmo0920
left a comment
There was a problem hiding this comment.
I added a very small nitpick. Could you check it?
…onfusion and issues going forward Signed-off-by: Dan Illescas <daniel.illescas@hpe.com>
cosmo0920
left a comment
cosmo0920
left a comment
There was a problem hiding this comment.
For technical terminology, it looks good to me.
|
@esmerel the vale lint failed, is this a blocker or just a run failure, can you check? I'm nudging on the code PR side (2x) to get this completed. |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
@eschabell I pushed a bunch of vale corrections - the one that test is failing on won't (or at least shouldn't) block the merge, you can still merge even though the button isn't green. In this case it's a test that needed an update to account for the capitalization, which I already fixed in main. I have no issues merging this PR as it is. |
eschabell
added
lint-vale-issues
and removed
waiting-on-review
eschabell
added
4.2.1
conflict
|
@illescad — I've rebased your branch to resolve the conflicts. You can update your PR branch with: git fetch upstream Where upstream is their remote pointing to fluent/fluent-bit-docs. Once you do this we can proceed with the rest of the issues to get this doc PR over the finish line. Thanks! |
eschabell
added
the
waiting-for-user
Resolve conflicts: - SUMMARY.md: insert openSUSE/SLES into master's alphabetized Linux list - installation/downloads.md: master replaced the table; openSUSE/SLES added to the new Linux bullet list instead - installation/getting-started-with-fluent-bit.md: accept upstream deletion (content consolidated into downloads.md) Also fix one vale error in suse.md (may -> might). Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
Warning Review limit reached
More reviews will be available in 4 minutes and 58 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a complete installation guide for Fluent Bit on openSUSE Leap and SUSE Linux Enterprise Server, including repository configuration, installation commands, and troubleshooting guidance. The new guide is indexed in the documentation navigation and table of contents. ChangesopenSUSE/SLES Installation Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~18 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
installation/downloads/linux/suse.md (1)
39-40:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUse
$releaseverconsistently in openSUSE instructions.The openSUSE section uses
$releaserverwhile the SLES section and explanatory text use$releasever. This inconsistency can lead to broken repo URLs when users copy/paste as-is.Suggested doc fix
-- `https://packages.fluentbit.io/opensuse/leap/$releaserver` +- `https://packages.fluentbit.io/opensuse/leap/$releasever` -1. Add the following content to the file (replace `$releaserver` with your Leap version. For example, `15.6`): +1. Add the following content to the file (replace `$releasever` with your Leap version, for example `15.6`): - baseurl=https://packages.fluentbit.io/opensuse/leap/$releaserver/ + baseurl=https://packages.fluentbit.io/opensuse/leap/$releasever/ -Ensure you use the correct `$releaserver` (for example, `15.6`) in your repo path: +Ensure you use the correct `$releasever` (for example, `15.6`) in your repo path:Also applies to: 44-45, 49-49, 118-119
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@installation/downloads/linux/suse.md` around lines 39 - 40, Replace the incorrect token `$releaserver` with the correct `$releasever` in the openSUSE/SLES repository URL examples and any explanatory text; search for occurrences of the string `$releaserver` and update them to `$releasever` (e.g., the repo URL `https://packages.fluentbit.io/opensuse/leap/$releaserver` and the other instances noted), ensuring all repo lines and explanatory mentions consistently use `$releasever`.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@installation/downloads/linux/suse.md`:
- Line 108: The sample systemd output line currently shows "-c
etc/fluent-bit/fluent-bit.conf" without the leading slash; update the example
string "└─3820 /opt/fluent-bit/bin/fluent-bit -c etc/fluent-bit/fluent-bit.conf"
to use an absolute path by changing "-c etc/fluent-bit/fluent-bit.conf" to "-c
/etc/fluent-bit/fluent-bit.conf" so the sample command is correct.
- Line 21: Fix the heading typo in the markdown heading "## Ensure you select
the correct openSUSE verse SLES Package" by replacing "verse" with "versus" so
it reads "## Ensure you select the correct openSUSE versus SLES Package"; update
that line in the installation/downloads/linux/suse.md file (look for the exact
heading string) and commit the corrected heading.
---
Duplicate comments:
In `@installation/downloads/linux/suse.md`:
- Around line 39-40: Replace the incorrect token `$releaserver` with the correct
`$releasever` in the openSUSE/SLES repository URL examples and any explanatory
text; search for occurrences of the string `$releaserver` and update them to
`$releasever` (e.g., the repo URL
`https://packages.fluentbit.io/opensuse/leap/$releaserver` and the other
instances noted), ensuring all repo lines and explanatory mentions consistently
use `$releasever`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9a035448-372c-49d1-bd00-f1dd89ef3b2b
📒 Files selected for processing (3)
SUMMARY.mdinstallation/downloads.mdinstallation/downloads/linux/suse.md
CI vale runs with -level=info -fail-on-error=true and flagged the SUSE
docs. Fix without changing vale-styles:
- Backtick command and variable names (`zypper`, `$releasever`,
`baseproduct`) so the Spelling rule treats them as code spans.
- Backtick brand names (`openSUSE`, `SLES`, `SUSE Linux Enterprise
Server`) in headings so the Headings capitalization rule treats them
as masked tokens.
- Fix typo in heading ("verse" -> "or"); lowercase trailing "Package".
- "is not recommended" -> "isn't recommended" (contraction).
- Expand casual abbreviations ("repo" -> "repository",
"distro" -> "distribution").
Signed-off-by: Eric D. Schabell <eric@schabell.org>
eschabell
removed
waiting-for-user
5 participants
Support for opensuse-leap 15.6 and sles 15.7 pacakging. See fluent-bit/10978 for implementation, resolves #10875
Summary by CodeRabbit