fix codec logic and failure handling#30
Draft
edsiper wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Several codec paths relied on unchecked conversion or allocator behavior. The OTLP dictionary builder did not construct the attribute table or copy profile metadata, MessagePack maps were not closed when MPack tracking was enabled, and multiple failure paths either lost ownership or cleaned up dangling pointers.
Validation
./scripts/agent-verify.shDEBUGtracking build and all four CTest executablescprof-test-opentelemetry_transcoder-fanalyzer; no project-source diagnostics remain (vendored CFL/MPack diagnostics only)An AddressSanitizer build completed, but its existing test binaries hung at their first test without emitting a sanitizer diagnostic, so ASan results are not claimed here.
Compatibility
No public C structure layouts or function signatures change. OTLP output now includes fields that were previously dropped and valid dictionary entries for existing attribute references. Malformed MessagePack integers that previously wrapped or truncated are now rejected.