array: report missing reference on removal#84
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return
-1fromcfl_array_remove_by_reference()when the supplied variant is not present in the array.Add unit coverage using a variant owned by a different array and verify that the failed removal leaves it unchanged.
Rationale
The previous implementation returned
0both when an element was removed and when no matching reference existed. Reporting the missing reference as an error makes the result meaningful and aligns it withcfl_array_remove_by_index()for an invalid position.No production callers were found in CFL, cmetrics, ctraces, or Fluent Bit.
Validation
ctest --test-dir build-array-remove -R cfl-test-array --output-on-failurectest --test-dir build-array-remove --output-on-failure(34/34 passed)git diff --check