ci: align validation with Fluent Bit consumers#83
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align CFL's CI with the environments and downstream libraries used by Fluent
Bit.
processors
Background
The ARM64 Clang job previously expanded
CCto an empty value and thereforeran GCC. CFL also had no downstream validation, so standalone tests could pass
even when a change could not be vendored into cmetrics, ctraces, or Fluent Bit.
Declaring the C standard before feature checks also prevents C11 APIs such as
timespec_get()from being detected under the compiler default and thencompiled into a GNU99 target.
Validation
sampling processors
git diff --check