build: use CFL-specific filename macro#81
Merged
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #54 by removing the redundant global
__FILENAME__=__FILE__compiler definition and using a CFL-specific filename macro in the logging interface.CFL_FILENAMEdefaults to__FILE__, so compiler path-remapping options such as-ffile-prefix-mapwork normally. Embedders can override the value without relying on the reserved__FILENAME__identifier or modifying globalCMAKE_C_FLAGS.Impact
CFL_FILENAME.cfl_report_runtime_error()behavior.Validation
-ffile-prefix-mappassed.$(subst ...), or$(abspath ...)expression.git diff --checkpassed.