docs(activation): fix profile.d ordering vs [vars] - #55
Open
djsauble wants to merge 1 commit into
Open
Conversation
profile.d scripts run before [vars] is set, not after — confirmed against Tanja's profile.d/plugins architecture doc. James caught the discrepancy in #53 while reviewing the merged activation-timeline change.
djsauble
commented
Jul 30, 2026
Comment on lines
+284
to
+285
| [[vars] section of your manifest](/man/manifest.toml#vars) — these aren't yet | ||
| visible to profile.d scripts, only to what runs after them. |
Contributor
Author
There was a problem hiding this comment.
"yet" is a weird word to use, since [[vars]] will never be visible to profile scripts due to the order in which they're run.
Suggested change
| [[vars] section of your manifest](/man/manifest.toml#vars) — these aren't yet | |
| visible to profile.d scripts, only to what runs after them. | |
| [[vars] section of your manifest](/man/manifest.toml#vars) — these aren't | |
| visible to profile.d scripts, only to what runs after them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profile.dstep to the activation timeline, but placed it after[vars]is set — the actual order is the reverse.[vars], before[hook].on-activate.[vars]is not yet visible to profile.d scripts.flox-activate.mdcomments, then confirmed the correct order via Tanja's doc himself.Found via later-triage while sweeping the control-DM thread for new saves.
Test plan