Correct the PHP-FPM process-model wording in the docs#5
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates documentation to accurately describe PHP-FPM’s request lifecycle (pooled/reused worker processes, but per-request teardown of PHP userland state), clarifying why in-memory storage resets each request and preventing a common misunderstanding about “new process per request”.
Changes:
- Reworded PHP-FPM behavior in the InMemoryCache storage characteristics to reflect userland state teardown rather than “new process”.
- Expanded the FAQ explanation to precisely describe pooled workers + per-request state reset.
- Adjusted the portable-config guidance to use the same accurate PHP-FPM wording.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/features/storage.md | Corrects the PHP-FPM explanation for why InMemoryCache resets each request. |
| docs/faq.md | Clarifies PHP-FPM pooling vs per-request userland teardown in the production warning for InMemoryCache. |
| docs/advanced/portable-config.md | Aligns PHP-FPM wording to accurately explain why configs are rebuilt per request. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.