.github/workflows: Migrate workflows to Blacksmith runners#2535
Open
blacksmith-sh[bot] wants to merge 7 commits into
Open
.github/workflows: Migrate workflows to Blacksmith runners#2535blacksmith-sh[bot] wants to merge 7 commits into
blacksmith-sh[bot] wants to merge 7 commits into
Conversation
Blacksmith runner images ship ext-redis 5.3.7, which conflicts with symfony/cache (requires ext-redis >= 6.1) and breaks composer install. No job in this repo needs the redis extension, so remove it via setup-php. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2535 +/- ##
============================================
Coverage 86.40% 86.40%
- Complexity 0 22975 +22975
============================================
Files 1749 1749
Lines 70532 70532
============================================
+ Hits 60944 60945 +1
+ Misses 9588 9587 -1 🚀 New features to boost your workflow:
|
actionlint rejects blacksmith-4vcpu-ubuntu-2404 as an unknown runner label, failing 'just lint'. Declare it as a self-hosted-runner label. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
zizmor's unpinned-uses audit (blanket pin-to-hash policy) failed on the useblacksmith/setup-docker-builder and useblacksmith/build-push-action references added by the migration. Pin them to full commit SHAs. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
symfony/cache v7.4 conflicts with ext-redis <6.1, and the Blacksmith runner image ships 5.3.7, which broke composer install. Rather than dropping the extension (which disables the PSRSimpleRedisCache tests the repo ships REDIS_HOST/REDIS_PORT config for), pin phpredis 6.3.0 via setup-php so a >=6.1 build compatible with PHP 8.3-8.5 is installed. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Right-size the migrated workflows down one tier from blacksmith-4vcpu-ubuntu-2404 to blacksmith-2vcpu-ubuntu-2404. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Those two jobs carry the heaviest load (job-tests stands up multiple service containers alongside PHPUnit; job-mutation-tests runs Infection with --threads=max), so keep them on blacksmith-4vcpu-ubuntu-2404 while the lighter workflows stay on the 2vcpu tier. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been automatically generated by a team member in your GitHub organization using Blacksmith's Migration Wizard. This PR changes the following:
runs-on: blacksmith-4vcpu-ubuntu-2204). Learn more about the different instances available to choose from.Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Need help on this PR? Tag
/codesmithwith what you need. Autofix is enabled.