Skip to content

fix: FEAT: Notification sound toggle (#1547) - #1605

Open
BWM0223 wants to merge 1 commit into
floatpane:masterfrom
BWM0223:fix-1547-1782078578
Open

fix: FEAT: Notification sound toggle (#1547)#1605
BWM0223 wants to merge 1 commit into
floatpane:masterfrom
BWM0223:fix-1547-1782078578

Conversation

@BWM0223

@BWM0223 BWM0223 commented Jun 21, 2026

Copy link
Copy Markdown

Fixes #1547

Automated by REAPR

@BWM0223
BWM0223 requested a review from a team as a code owner June 21, 2026 21:49

@floatpanebot floatpanebot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BWM0223! Please fix the following issues with your PR:

  • Title: Is too long (44 characters). The PR title must be strictly under 40 characters.
  • Body: Missing the ## What? or ## Why? headings required by the PR template.

@floatpanebot floatpanebot added bug Something isn't working size/S Diff: 11–50 lines labels Jun 21, 2026
@floatpanebot

Copy link
Copy Markdown
Member

Benchmark report — no significant change

Metrics worse: 0 · better: 0 (threshold: ±3%).

benchstat output
goos: linux
goarch: amd64
pkg: github.com/floatpane/matcha/backend
cpu: AMD EPYC 9V74 80-Core Processor                
                           │    old.txt    │               new.txt               │
                           │    sec/op     │    sec/op     vs base               │
ParseSearchQuery_Simple-4    3.914µ ± 271%   1.863µ ± 66%  -52.41% (p=0.015 n=6)
ParseSearchQuery_Complex-4   7.298µ ±  18%   9.424µ ± 41%        ~ (p=0.093 n=6)
TokenizeSearchQuery-4        4.133µ ± 179%   3.964µ ± 35%        ~ (p=0.818 n=6)
geomean                      4.906µ          4.113µ        -16.16%

                           │  old.txt   │              new.txt               │
                           │    B/op    │    B/op     vs base                │
ParseSearchQuery_Simple-4    26.00 ± 0%   26.00 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   762.0 ± 0%   762.0 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        176.0 ± 0%   176.0 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      151.6        151.6       +0.00%
¹ all samples are equal

                           │  old.txt   │              new.txt               │
                           │ allocs/op  │ allocs/op   vs base                │
ParseSearchQuery_Simple-4    2.000 ± 0%   2.000 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   23.00 ± 0%   23.00 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        9.000 ± 0%   9.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      7.453        7.453       +0.00%
¹ all samples are equal

pkg: github.com/floatpane/matcha/tui
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
LogPanelView-4        168.9µ ± 15%   167.0µ ± 21%       ~ (p=0.589 n=6)
SearchOverlayView-4   185.0µ ± 11%   187.4µ ± 14%       ~ (p=0.485 n=6)
InboxConstruction-4   1.066m ± 10%   1.017m ± 10%       ~ (p=0.310 n=6)
geomean               321.8µ         317.0µ        -1.47%

                    │    old.txt    │               new.txt               │
                    │     B/op      │     B/op       vs base              │
LogPanelView-4        44.67Ki ± 51%   44.67Ki ± 51%       ~ (p=1.000 n=6)
SearchOverlayView-4   44.67Ki ± 26%   56.14Ki ± 41%       ~ (p=0.126 n=6)
InboxConstruction-4   874.2Ki ±  0%   874.3Ki ±  0%       ~ (p=0.699 n=6)
geomean               120.4Ki         129.9Ki        +7.92%

                    │   old.txt   │              new.txt              │
                    │  allocs/op  │  allocs/op   vs base              │
LogPanelView-4         714.0 ± 0%    714.0 ± 0%       ~ (p=1.000 n=6)
SearchOverlayView-4    925.0 ± 0%    926.0 ± 0%       ~ (p=0.188 n=6)
InboxConstruction-4   3.478k ± 0%   3.478k ± 0%       ~ (p=1.000 n=6)
geomean               1.319k        1.320k       +0.04%

auto-generated by benchmarks.yml

@floatpanebot floatpanebot added the stale No activity for extended period label Aug 6, 2026
@floatpanebot

Copy link
Copy Markdown
Member

This has had no activity for 45 days. It will be closed in 21 days unless updated. Comment or remove the stale label to keep it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size/S Diff: 11–50 lines stale No activity for extended period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEAT: Notification sound toggle

2 participants