Skip to content

Context bar updates - #744

Merged
lawsie merged 4 commits into
flipcomputing:mainfrom
lawsie:context-bar-updates-liz
Aug 11, 2026
Merged

Context bar updates#744
lawsie merged 4 commits into
flipcomputing:mainfrom
lawsie:context-bar-updates-liz

Conversation

@lawsie

@lawsie lawsie commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Switch the enable/disable icon in the context toolbar to show the opposite state from current
image
  • Add duplicate/comment buttons to the toolbar for detached blocks, and remove enable/disable because the block is always disabled
image
  • Add tooltips for all blocks (and associated translations)
image

Summary by CodeRabbit

  • New Features
    • Added translated labels for block deletion, duplication, comments, canvas viewing, and block detachment in eight languages.
    • Improved toolbar accessibility with synchronized labels and tooltips.
  • Bug Fixes
    • Corrected enable/disable icon states.
    • Improved toolbar visibility for locked and loose blocks.
    • Ensured labels update correctly when the language changes.

@lawsie lawsie changed the title Context bar updates liz Context bar updates Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@lawsie, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b9216724-fe9a-4873-8485-13940d3682e0

📥 Commits

Reviewing files that changed from the base of the PR and between 341e792 and 6586eb3.

📒 Files selected for processing (1)
  • ui/contextmenu.js
📝 Walkthrough

Walkthrough

The change adds block toolbar and context-menu translations in eight locales. It centralizes toolbar labels and titles, refreshes localized labels, and adjusts toolbar visibility, enable-state icons, dynamic labels, and canvas-view exit text.

Changes

Block toolbar localization and behavior

Layer / File(s) Summary
Add toolbar and context-menu translations
locale/*.js
Adds translations for block deletion, duplication, comments, canvas viewing, canvas-view exit, and block detachment in German, English, Spanish, French, Italian, Polish, Portuguese, and Swedish.
Centralize static toolbar labels
ui/contextmenu.js
Adds shared label handling for aria-label and title, and refreshes static toolbar labels when the toolbar is shown.
Align toolbar state and visibility
ui/contextmenu.js
Updates toolbar visibility, enable-state icons, dynamic labels, and the canvas-view exit fallback text.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

Suggested reviewers: tracygardner, claude

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the main change as updates to the context toolbar, although it does not specify the icon, action, or translation changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@locale/pt.js`:
- Around line 1086-1087: Update delete_block_button_ui in locale/pt.js to use
the European Portuguese wording “Eliminar bloco”, matching delete_button_ui and
the locale’s existing Portuguese variant; leave duplicate_block_button_ui
unchanged.

In `@ui/contextmenu.js`:
- Around line 1037-1039: Update updateSimplifiedToolbar() to refresh
detachBtn.style.display based on the current toolbar block’s detachment state,
ensuring a detached block hides Detach alongside Enable and View while Duplicate
and Comment remain visible. Verify the BLOCK_MOVE refresh path applies these
visibility states after detaching.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e867e12-d227-4290-8165-a26efa18c82e

📥 Commits

Reviewing files that changed from the base of the PR and between e828e95 and 341e792.

📒 Files selected for processing (9)
  • locale/de.js
  • locale/en.js
  • locale/es.js
  • locale/fr.js
  • locale/it.js
  • locale/pl.js
  • locale/pt.js
  • locale/sv.js
  • ui/contextmenu.js

Comment thread locale/pt.js
Comment thread ui/contextmenu.js Outdated
@lawsie
lawsie merged commit 773ad03 into flipcomputing:main Aug 11, 2026
3 checks passed
@lawsie
lawsie deleted the context-bar-updates-liz branch August 11, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant