Skip to content

Bugfix: Apply transformations to correct mesh when duplicated #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawsie merged 1 commit into from
Aug 6, 2026
Merged

Bugfix: Apply transformations to correct mesh when duplicated #740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions blocks/blocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,17 +752,20 @@ function createFreshVariable(workspace, prefix, type, nextVariableIndexes) {
function retargetDescendantsVariables(rootBlock, fromVarId, toVarId, BlocklyNS, createdIds = null) {
if (!fromVarId || !toVarId || fromVarId === toVarId) return 0;

// Get descendants but ONLY through input connections, not next/previous
// Get descendants but ONLY through input connections, not the root's own next/previous
const descendants = [];

function collectInputDescendants(block) {
for (const input of block.inputList || []) {
if (input.connection && input.connection.targetBlock()) {
const childBlock = input.connection.targetBlock();
// Only include if it was created in the same event (if createdIds is provided)
if (!createdIds || createdIds.has(childBlock.id)) {
descendants.push(childBlock);
collectInputDescendants(childBlock);
let childBlock = input.connection.targetBlock();
while (childBlock) {
// Only include if it was created in the same event (if createdIds is provided)
if (!createdIds || createdIds.has(childBlock.id)) {
descendants.push(childBlock);
collectInputDescendants(childBlock);
}
childBlock = childBlock.getNextBlock();
}
}
}
Expand Down Expand Up @@ -834,9 +837,10 @@ function adoptIsolatedDefaultVarsTo(
const descendants = [];
for (const input of block.inputList || []) {
if (input.connection && input.connection.targetBlock()) {
const childBlock = input.connection.targetBlock();
descendants.push(childBlock);
descendants.push(...collectInputDescendants(childBlock));
for (let childBlock = input.connection.targetBlock(); childBlock; childBlock = childBlock.getNextBlock()) {
descendants.push(childBlock);
descendants.push(...collectInputDescendants(childBlock));
}
}
}
return descendants;
Expand Down
Loading