Skip to content

Add visible shadow to workspace comments - #738

Merged
lawsie merged 1 commit into
flipcomputing:mainfrom
lawsie:ws-comment-outline
Aug 6, 2026
Merged

Add visible shadow to workspace comments#738
lawsie merged 1 commit into
flipcomputing:mainfrom
lawsie:ws-comment-outline

Conversation

@lawsie

@lawsie lawsie commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Make the highlight outline when a workspace comment is focused actually visible in all themes.

image image

AI usage

Claude Sonnet 5 worked out why the outline was displaying as a very thin line and suggested adding the drop shadow to combat the problem of contrast against something light and something dark simultaneously.

Summary by CodeRabbit

  • Style
    • Added a purple highlight with a white outline for selected comments.
    • Applied the highlight consistently to both expanded and collapsed comments.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d0250704-5d9e-43bc-921f-8f87647d3e7c

📥 Commits

Reviewing files that changed from the base of the PR and between 823f1af and 98ef022.

📒 Files selected for processing (1)
  • style/blockly.css

📝 Walkthrough

Walkthrough

The stylesheet adds selected-comment highlights for expanded and collapsed comments. The highlights use a purple non-scaling stroke and white drop-shadow outlines.

Changes

Selected comment styling

Layer / File(s) Summary
Comment highlight styles
style/blockly.css
Adds purple non-scaling strokes and white drop-shadow outlines for selected comments and collapsed selected comment topbars.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tracygardner

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a visible shadow to workspace comments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawsie
lawsie merged commit c759527 into flipcomputing:main Aug 6, 2026
3 checks passed
@lawsie
lawsie deleted the ws-comment-outline branch August 6, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant