Skip to content

Reposition context bar for hat blocks - #736

Merged
lawsie merged 1 commit into
flipcomputing:mainfrom
lawsie:dont-clip
Aug 4, 2026
Merged

Reposition context bar for hat blocks#736
lawsie merged 1 commit into
flipcomputing:mainfrom
lawsie:dont-clip

Conversation

@lawsie

@lawsie lawsie commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

When the context bar would overlap the toolbox, instead move it right so that the left edge is always clear of the toolbox

image

AI usage

Claude Opus made the changes.

Summary by CodeRabbit

  • Bug Fixes
    • Toolbar badges now display correctly for all visible buttons without being clipped.
    • Improved toolbar positioning within toolboxes, flyouts, and the viewport.
    • Toolbar carets remain aligned when the toolbar shifts to stay on-screen.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b27171a-db8d-45db-b57a-a7c36eadaa21

📥 Commits

Reviewing files that changed from the base of the PR and between 4fe5845 and a097345.

📒 Files selected for processing (1)
  • ui/contextmenu.js

📝 Walkthrough

Walkthrough

The toolbar now renders badges for all visible buttons. Its position is clamped against the viewport and toolbox or flyout edge. The caret remains aligned within the toolbar bounds.

Changes

Toolbar layout behavior

Layer / File(s) Summary
Badge rendering and toolbar position clamping
ui/contextmenu.js
Visible toolbar buttons no longer use toolbox-based badge clipping. Toolbar and caret positions now use viewport, toolbox, and flyout bounds.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: repositioning the context bar for hat blocks to prevent toolbox overlap.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawsie

lawsie commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@lawsie
lawsie merged commit f622588 into flipcomputing:main Aug 4, 2026
3 checks passed
@lawsie
lawsie deleted the dont-clip branch August 4, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant