Skip to content

Document pg up/down on mac - #734

Merged
lawsie merged 1 commit into
flipcomputing:mainfrom
lawsie:document-mac-pgup-down
Aug 4, 2026
Merged

Document pg up/down on mac#734
lawsie merged 1 commit into
flipcomputing:mainfrom
lawsie:document-mac-pgup-down

Conversation

@lawsie

@lawsie lawsie commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Page Up and Page Down keys don't exist on Mac. Add a modifier in the keyboard controls documentation to document the correct keys on Mac.

AI usage

Claude Sonnet 5 was my wingman today but all it really did was write the line, I did everything else.

Summary by CodeRabbit

  • Bug Fixes
    • Updated shortcut instructions to display the correct Page Up/Page Down key labels based on the user’s platform.
    • macOS now shows Fn + ↑ ↓, while other platforms show PgUp PgDn.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ec1d912-7bac-4345-b76b-272174208fe9

📥 Commits

Reviewing files that changed from the base of the PR and between e0d499b and ee41d49.

📒 Files selected for processing (1)
  • accessibility/keyboardui.js

📝 Walkthrough

Walkthrough

The keyboard shortcut display now shows Fn + ↑ ↓ on Mac and PgUp PgDn on other platforms. The 3D transform shortcut uses the platform-specific label.

Changes

Shortcut label rendering

Layer / File(s) Summary
Platform-specific page-navigation shortcut
accessibility/keyboardui.js
Defines the platform-specific pgUpDn label and uses it in the 3D transform shortcut display.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tracygardner

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: documenting Mac equivalents for Page Up and Page Down.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawsie
lawsie merged commit bf334d9 into flipcomputing:main Aug 4, 2026
3 checks passed
@lawsie
lawsie deleted the document-mac-pgup-down branch August 4, 2026 07:57
@coderabbitai coderabbitai Bot mentioned this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant